Date: Thu, 16 Jan 2014 17:50:01 GMT From: Graham Todd <gtodd@bellanet.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/181507: [PATCH] security/pks: fix autostart Message-ID: <201401161750.s0GHo1tF078994@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/181507; it has been noted by GNATS.
From: Graham Todd <gtodd@bellanet.org>
To: Edwin Groothuis <edwin@freebsd.org>, bug-followup@freebsd.org
Cc: Tassilo Philipp <tphilipp@potion-studios.com>
Subject: Re: ports/181507: [PATCH] security/pks: fix autostart
Date: Thu, 16 Jan 2014 12:45:36 -0500 (EST)
Thanks for this report. The good news is that folks are still using pks
and it builds with STAGE :-)
I can confirm this bug, however I don't think the patch as is should be
accepted.
The use of 'daemon' seems a bit like a workaround for something that isn't
working quite correctly, but which I have been unable to track down. I
believe the issue appeared after there were changes made in the rc.subr
system and pksd.sh moved to pksd.
The patch Tassilo submitted does fix the start on boot issue but breaks
onestart/onestatus/onestop behaviour. Setting a ${pidfile} fixes this
follow on issue (but doesn't feel like a complete solution either since I
am not sure why it changes the behaviour the way it does). The use of
"daemon" adds another running process after startup but I suppose this is
acceptable tradeoff.
In the next few days I will submit a modified patch that corrects the
start/onestart behaviours and a couple of other issues with the sample
configuration file and the rc script.
I will use the present PR (ports/181507) to track the changes.
Thanks for your report!
Cheers
On Sat, 24 Aug 2013, Edwin Groothuis wrote:
> Maintainer of security/pks,
>
> Please note that PR ports/181507 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181507
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401161750.s0GHo1tF078994>