Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Apr 2007 12:15:01 +0300
From:      Kostik Belousov <kostikbel@gmail.com>
To:        Kris Kennaway <kris@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/pci if_vr.c
Message-ID:  <20070401091501.GK18105@deviant.kiev.zoral.com.ua>
In-Reply-To: <20070401070403.16724517E2@repoman.freebsd.org>
References:  <20070401070403.16724517E2@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--J2uG6jHjFLimDtBY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 01, 2007 at 07:03:43AM +0000, Kris Kennaway wrote:
> kris        2007-04-01 07:03:43 UTC
>=20
>   FreeBSD src repository
>=20
>   Modified files:
>     sys/pci              if_vr.c=20
>   Log:
>   Fix a search-and-replace bug that slipped through my diff review of the
>   Giant pushdown.
>  =20
>   Submitted by:   cperciva
>  =20
>   Revision  Changes    Path
>   1.119     +2 -2      src/sys/pci/if_vr.c

Did you ever test _your_ changes, at least with half of the care you
put into finding bugs in commits of others ?

You fixed the if_vr.c, but not the flag definition in if_vrreg.h, thus
breaking the build !

I hope that all this would be sorted out before end of April, 1.

--J2uG6jHjFLimDtBY
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)

iD8DBQFGD3gVC3+MBN1Mb4gRAqX1AJwO+0/fzxLMpRLQtKNuDpBhWsDJlQCgnPsz
/dAXueVT8Z5+s6nNYouO2Lk=
=YGEW
-----END PGP SIGNATURE-----

--J2uG6jHjFLimDtBY--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070401091501.GK18105>