Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 Nov 2006 23:30:21 GMT
From:      Matt Jacob <mjacob@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 109080 for review
Message-ID:  <200611022330.kA2NULcV091330@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=109080

Change 109080 by mjacob@newisp on 2006/11/02 23:30:18

	Replace PPR options bounce with a comment asserting that we
	don't have to care about changing PPR options.

Affected files ...

.. //depot/projects/newisp/cam/cam_xpt.c#8 edit

Differences ...

==== //depot/projects/newisp/cam/cam_xpt.c#8 (text+ko) ====

@@ -5907,13 +5907,10 @@
 	}
 
 	/*
-	 * XXX: skipping PPR options
+	 * We'll assert that we don't have to touch PPR options- the
+	 * SIM will see what we do with period and offset and adjust
+	 * the PPR options as appropriate.
 	 */
-	if ((spi->valid & CTS_SPI_VALID_PPR_OPTIONS) != 0) {
-		xpt_print_path(periph->path);
-		printf("XXX PPR options not handled yet\n");
-		return (0);
-	}
 
 	/*
 	 * A sync rate with unknown or zero offset is nonsensical.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611022330.kA2NULcV091330>