Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Jun 2018 20:03:11 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Warner Losh <imp@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r335091 - head/sbin/nvmecontrol
Message-ID:  <201806140303.w5E33BYj042496@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201806132200.w5DM03bF097193@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Author: imp
> Date: Wed Jun 13 22:00:02 2018
> New Revision: 335091
> URL: https://svnweb.freebsd.org/changeset/base/335091
> 
> Log:
>   Make it possible to use print_controller from another program
>   
>   Rename print_controller to nvme_print_controller. Put it in its
>   own file for easy inclusion. Move util.c to be nc_util.c to not
>   conflict with camcontrol. add nvecontrol_ext.h to define shared
>   interfaces.
>   
>   Sponsored by: Netflix
>   Differential Revision: https://reviews.freebsd.org/D15371
> 
> Added:
>   head/sbin/nvmecontrol/identify_ext.c
>      - copied, changed from r335089, head/sbin/nvmecontrol/identify.c
>   head/sbin/nvmecontrol/nc_util.c
>      - copied, changed from r335089, head/sbin/nvmecontrol/util.c
>   head/sbin/nvmecontrol/nvmecontrol_ext.h   (contents, props changed)
>      - copied, changed from r335089, head/sbin/nvmecontrol/util.c
...

> 
> Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from r335089, head/sbin/nvmecontrol/util.c)
> ==============================================================================
> --- head/sbin/nvmecontrol/util.c	Wed Jun 13 21:10:23 2018	(r335089, copy source)
> +++ head/sbin/nvmecontrol/nvmecontrol_ext.h	Wed Jun 13 22:00:02 2018	(r335091)
> @@ -1,7 +1,8 @@
>  /*-
> - * Copyright (c) 2017 Netflix, Inc
> - * All rights reserved.
> + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
>   *
> + * Copyright (C) 2018 Netflix

You moved a copyright forward, that is not proper to do.
Not sure about dropping the , Inc either.

> + *
>   * Redistribution and use in source and binary forms, with or without
>   * modification, are permitted provided that the following conditions
>   * are met:
> @@ -22,38 +23,8 @@
>   * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
>   * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
>   * SUCH DAMAGE.
> + *
> + * $FreeBSD$
>   */
>  

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806140303.w5E33BYj042496>