From owner-freebsd-pf@FreeBSD.ORG Thu Sep 16 04:07:14 2004 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 674) id C392516A4CF; Thu, 16 Sep 2004 04:07:14 +0000 (GMT) Delivered-To: mlaier@vampire.homelinux.org Received: (qmail 21286 invoked by alias); 22 Jun 2004 01:07:35 -0000 Delivered-To: max@vampire.homelinux.org Received: (qmail 21283 invoked from network); 22 Jun 2004 01:07:35 -0000 Received: from moutng.kundenserver.de (212.227.126.186) by p548085b6.dip.t-dialin.net with SMTP; 22 Jun 2004 01:07:35 -0000 Received: from [212.227.126.153] (helo=mxng02.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BcZlA-0002MF-00 for max@vampire.homelinux.org; Tue, 22 Jun 2004 03:07:36 +0200 Received: from [206.53.239.180] (helo=turing.freelists.org) by mxng02.kundenserver.de with esmtp (Exim 3.35 #1) id 1BcZl9-00013L-00 for max@love2party.net; Tue, 22 Jun 2004 03:07:35 +0200 Received: from localhost (localhost [127.0.0.1])ESMTP id 48D7B72C09A; Mon, 21 Jun 2004 19:46:15 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 02867-40; Mon, 21 Jun 2004 19:46:15 -0500 (EST) Received: from turing (localhost [127.0.0.1])ESMTP id A6B5E72C17A; Mon, 21 Jun 2004 19:46:14 -0500 (EST) Received: with ECARTIS (v1.0.0; list pf4freebsd); Mon, 21 Jun 2004 19:45:59 -0500 (EST) X-Original-To: pf4freebsd@freelists.org Delivered-To: pf4freebsd@freelists.org Received: from localhost (localhost [127.0.0.1])ESMTP id 1A36072C09A for ; Mon, 21 Jun 2004 19:45:59 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 02867-35 for ; Mon, 21 Jun 2004 19:45:58 -0500 (EST) Received: from mr01.hansenet.de (mr01.hansenet.de [213.191.74.10]) ESMTP id 965B072C0F7 for ; Mon, 21 Jun 2004 19:45:58 -0500 (EST) Received: from mail.nipsi.de (213.39.193.146) by mr01.hansenet.de (5.5.053) id 40D2A2A9000059E1 for pf4freebsd@freelists.org; Tue, 22 Jun 2004 03:07:17 +0200 Received: from blackbox.home.net (blackbox.home.net [172.16.1.13]) by mail.nipsi.de with esmtp; Tue, 22 Jun 2004 03:11:52 +0200 Received: from [IPv6:::1] (localhost [IPv6:::1]) by blackbox.home.net (8.12.11/8.12.11) with ESMTP id i5M175PV000813 for ; Tue, 22 Jun 2004 03:07:05 +0200 (CEST) (envelope-from db@nipsi.de) Message-ID: <40D78638.3030901@nipsi.de> From: Dennis Berger User-Agent: Mozilla Thunderbird 0.6 (X11/20040522) X-Accept-Language: en-us, en MIME-Version: 1.0 To: pf4freebsd@freelists.org References: <40D760E5.7000903@nipsi.de> <200406220143.05302.max@love2party.net> In-Reply-To: <200406220143.05302.max@love2party.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at freelists.org X-archive-position: 345 X-ecartis-version: Ecartis v1.0.0 Sender: pf4freebsd-bounce@freelists.org Errors-To: pf4freebsd-bounce@freelists.org X-original-sender: db@nipsi.de Precedence: normal X-list: pf4freebsd X-Virus-Scanned: by amavisd-new at freelists.org X-Provags-Forward: max@love2party.net -> max@vampire.homelinux.org X-UID: 461 X-Length: 5457 X-Mailman-Approved-At: Thu, 16 Sep 2004 04:12:49 +0000 Subject: [pf4freebsd] Re: if_fxp.c.patch X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.1 Reply-To: pf4freebsd@freelists.org List-Id: Technical discussion and general questions about packet filter (pf) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Thu, 16 Sep 2004 04:07:14 -0000 X-Original-Date: Tue, 22 Jun 2004 03:07:04 +0200 X-List-Received-Date: Thu, 16 Sep 2004 04:07:14 -0000 Max Laier wrote: >On Tuesday 22 June 2004 00:27, Dennis Berger wrote: > > >>Hi, >>today I tried the fxp driver patch and run into a kernelpanic if altq is >>enabled. >>I guess it's something strange with the locking cause the debugger stops at >>fxp_start_body(); >>this is exactly the point where a lock is needed, or whatever there >>happens... >> >>pyun discovered similar problems months ago, he fixed it by modifying >>the LOCK macro. >>to something like this >> >>#define MY_LOCK do { \ >> if(!mtx_owned(&lock) \ >> mtx_lock(&lock); \ >> } while(0) >>and >>#define MY_UNLOCK do { \ >> if(mtx_owned(&lock)); \ >> mtx_unlock(&lock); \ >> } while(0) >> >>I don't know why he have to check if the lock is held... >> >> > >Neither do I, but maybe you can provide a complete trace of this panic so we >can find the real problem instead of fixing the symptoms? Moreover, if there >is a panic *in* fxp_start_body that means that we fail the mtx_assert (i.e. >the lock was not properly acquired), above fix will not help it. > > > stopped at fxp_start_body:+0x256 sorry I can't get my kernel to dump core... I dunno why DDB>panic doesn't dump core... and "call boot(0)" doesn't sync my disks either *argl* I can't write off the whole trace... I need to get my kernel to dump core. maybe tomorrow more. >Please provide the complete (function names are enough for a start) trace from >that panic in order to give me an idea of the panic. Please also tell me what >kind of queues you have set up. > > > altq.pf.test >Thanks. > > > -db