Date: Sun, 15 Dec 2002 21:13:54 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: "David E. O'Brien" <obrien@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/boot/i386/boot2 boot2.c Message-ID: <20021215211052.I10706-100000@gamplex.bde.org> In-Reply-To: <200212150215.gBF2FKbq066736@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> obrien 2002/12/14 18:15:19 PST > > Modified files: > sys/boot/i386/boot2 boot2.c > Log: > Remove unneeded casts. Add others to make WARNS=5 happy. Er, this breaks strcmp() some more by removing a needed cast. strcmp() compares unsigned chars. Even more casts are needed to unbreak strcmp() on exotic machines. See another thread about one-true-awk. boot2 might not need a non-broken strcmp(), but there is no reason to use a broken one there. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021215211052.I10706-100000>