From owner-cvs-all  Sun Dec 15  2:13: 9 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D940F37B401; Sun, 15 Dec 2002 02:13:08 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4C9AD43EC5; Sun, 15 Dec 2002 02:13:07 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id VAA09486;
	Sun, 15 Dec 2002 21:13:05 +1100
Date: Sun, 15 Dec 2002 21:13:54 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "David E. O'Brien" <obrien@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/boot/i386/boot2 boot2.c
In-Reply-To: <200212150215.gBF2FKbq066736@repoman.freebsd.org>
Message-ID: <20021215211052.I10706-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> obrien      2002/12/14 18:15:19 PST
>
>   Modified files:
>     sys/boot/i386/boot2  boot2.c
>   Log:
>   Remove unneeded casts.  Add others to make WARNS=5 happy.

Er, this breaks strcmp() some more by removing a needed cast.  strcmp()
compares unsigned chars.  Even more casts are needed to unbreak strcmp()
on exotic machines.  See another thread about one-true-awk.  boot2
might not need a non-broken strcmp(), but there is no reason to use a
broken one there.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message