Date: Fri, 22 Jul 2016 04:46:57 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kris Moore <kmoore@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r418889 - in head/deskutils: . copyq Message-ID: <20160722044657.GC37437@FreeBSD.org> In-Reply-To: <201607211847.u6LIluTh087613@repo.freebsd.org> References: <201607211847.u6LIluTh087613@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 21, 2016 at 06:47:56PM +0000, Kris Moore wrote: > New Revision: 418889 > URL: https://svnweb.freebsd.org/changeset/ports/418889 > > Log: > CopyQ is advanced clipboard manager with editing and scripting features. > > WWW: https://github.com/hluk/CopyQ > > [...] > +USE_XORG+= x11 xfixes xtst What's the reason for += here? > +USE_QT5= core gui network svg multimedia imageformats \ Spaces were used in this line instead of proper tab. > +USE_GL+= gl Bogus += again. > +USES= qmake Spaces again; also it's better to place more generic USES *before* specific USE_FOO knobs. > +PLIST_FILES= bin/copyq PLIST-related knobs should be among the last ones (after USE* knobs, but before OPTIONS* knobs). > +do-install: > + ${INSTALL_PROGRAM} ${WRKSRC}/copyq ${STAGEDIR}${PREFIX}/bin/copyq Last component of destination is redundant (${STAGEDIR}${PREFIX}/bin would be enough). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160722044657.GC37437>