From owner-cvs-src@FreeBSD.ORG  Tue Jun  3 12:38:18 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 451721065685;
	Tue,  3 Jun 2008 12:38:18 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 357E78FC2A;
	Tue,  3 Jun 2008 12:38:18 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m53CcIEW039609;
	Tue, 3 Jun 2008 12:38:18 GMT (envelope-from ed@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m53CcIVv039608;
	Tue, 3 Jun 2008 12:38:18 GMT (envelope-from ed@repoman.freebsd.org)
Message-Id: <200806031238.m53CcIVv039608@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	ed@repoman.freebsd.org using -f
From: Ed Schouten <ed@FreeBSD.org>
Date: Tue, 3 Jun 2008 12:38:00 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/kern tty_tty.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jun 2008 12:38:18 -0000

ed          2008-06-03 12:38:18 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             tty_tty.c 
  Log:
  SVN rev 179519 on 2008-06-03 12:38:00Z by ed
  
  Remove unneeded Giant locking of /dev/tty.
  
  The Giant lock is acquired in two places in tty_tty.c. In both places,
  it is unneeded.
  
  There is no reason to specify D_NEEDGIANT on this device node. The
  device node has only been designed to return ENXIO when opened. It
  doesn't make any sense to lock/unlock Giant, just to return this error.
  D_TTY is also unneeded. The unimplemented functions don't need to be
  patched by devfs.
  
  We don't need to lock Giant when we want to lookup the proper TTY vnode.
  s_ttyvp is already protected by proctree_lock (see devfs_vnops.c).
  
  Approved by:    philip (mentor)
  
  Revision  Changes    Path
  1.62      +0 -3      src/sys/kern/tty_tty.c