Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Jul 2003 15:06:57 +0200
From:      Pawel Jakub Dawidek <nick@garage.freebsd.pl>
To:        Mike Makonnen <mtm@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern kern_umtx.c
Message-ID:  <20030704130657.GP4973@garage.freebsd.pl>
In-Reply-To: <200307041118.h64BI8h0086394@repoman.freebsd.org>
References:  <200307041118.h64BI8h0086394@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--l2C7pJE7HE4aLL3l
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 04, 2003 at 04:18:08AM -0700, Mike Makonnen wrote:
+>   Commiter:	Mike Makonnen <mtm@FreeBSD.org>
+>   Branch:	HEAD
+>=20
+>   Files:
+> 	1.6   src/sys/kern/kern_umtx.c =20
+>=20
+>   Log:
+>   It's unfair how one extraneous semi-colon can cause so much grief.
+>  =20
+>=20
+> Diffs:
+> URL: http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/kern/kern_umtx.c.diff=
?r1=3D1.5&r2=3D1.6
+> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
+> RCS file: /usr/local/www/cvsroot/FreeBSD/src/sys/kern/kern_umtx.c,v
+> retrieving revision 1.5
+> retrieving revision 1.6
+> diff -u -p -r1.5 -r1.6
+> --- src/sys/kern/kern_umtx.c	2003/06/11 00:56:57	1.5
+> +++ src/sys/kern/kern_umtx.c	2003/07/04 11:18:07	1.6
+> @@ -25,7 +25,7 @@
[...]
+> =20
+> -			if (owner =3D=3D MTX_CONTESTED);
+> +			if (owner =3D=3D MTX_CONTESTED)
+>  				return (0);

Simlar bug is here:

/sys/dev/en/midway.c
408:	printf("\n");
409:	if (totlen !=3D plen);
410:		printf("sum of m_len=3D%u\n", totlen);

But it doesn't look critical:)

--=20
Pawel Jakub Dawidek                       pawel@dawidek.net
UNIX Systems Programmer/Administrator     http://garage.freebsd.pl
Am I Evil? Yes, I Am!                     http://cerber.sourceforge.net

--l2C7pJE7HE4aLL3l
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iQCVAwUBPwV78T/PhmMH/Mf1AQFatQP/dnaq2GUa369bKuWgDdidsYx6bvvoqWD/
OX95XelrE3tAW7NwmLOZB7Ifei+wzZxWOaHp5knyopKEkvm/lh2cLMBQ6FhzFoMJ
XnsNuiVWTFSH2CzxA0BtStdF4TgDqIG7dZCN234qiYPVL+3ni2D0/X973zvpp+pa
0F5fgrkBTRQ=
=TWxL
-----END PGP SIGNATURE-----

--l2C7pJE7HE4aLL3l--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030704130657.GP4973>