From owner-svn-src-head@freebsd.org Fri Jan 26 14:03:37 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C942DED8363; Fri, 26 Jan 2018 14:03:37 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2EB4E741CF; Fri, 26 Jan 2018 14:03:36 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with ESMTPA id f4bHe95NAZ8gBf4bIeMgcc; Fri, 26 Jan 2018 07:03:29 -0700 X-Authority-Analysis: v=2.2 cv=M/g9E24s c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=RgaUWeydRksA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=hmGqi0VmbsYnmpwqu18A:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 47B5E1F3E; Fri, 26 Jan 2018 06:03:27 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w0QE3Qhg016587; Fri, 26 Jan 2018 06:03:26 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w0QE3Qxf016584; Fri, 26 Jan 2018 06:03:26 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201801261403.w0QE3Qxf016584@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Conrad Meyer cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328417 - in head/sys: contrib/ipfilter/netinet fs/nfs fs/nfsclient fs/nfsserver netinet nfsclient sys In-Reply-To: Message from Conrad Meyer of "Thu, 25 Jan 2018 22:25:13 +0000." <201801252225.w0PMPDVQ023040@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 26 Jan 2018 06:03:26 -0800 X-CMAE-Envelope: MS4wfGEvNTrVX+gJSgux0k4E5j1priK9WGyElxZ6uVJhjrfxGVtmRwmO1srZW9VY0INk09QHgDgZV4V4pq6rSvs7yDVewa+ycbI8F7VIv6kCULbzAKE0G5B7 TVNEnuVQ0XYtIiFbHnuRRd1tBzKrnlt6PF1jjZGd9KXN18QbqRiOJnhYbG0QCgBNZgtCy8ETFWfv2EAtII3hXXude7RMmyRNSt5HcRUcwD0JQjitVie88HM8 2MBihjqZZ+CDfDqyixSdvar90+MnWH7voJxF4Tyjkuv7oxb6urPA2l/vVruO5ENK X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 14:03:38 -0000 In message <201801252225.w0PMPDVQ023040@repo.freebsd.org>, Conrad Meyer writes: > Author: cem > Date: Thu Jan 25 22:25:13 2018 > New Revision: 328417 > URL: https://svnweb.freebsd.org/changeset/base/328417 > > Log: > style: Remove remaining deprecated MALLOC/FREE macros > > Mechanically replace uses of MALLOC/FREE with appropriate invocations of > malloc(9) / free(9) (a series of sed expressions). Something like: > > * MALLOC(a, b, ... -> a = malloc(... > * FREE( -> free( > * free((caddr_t) -> free( > > No functional change. > > For now, punt on modifying contrib ipfilter code, leaving a definition of > the macro in its KMALLOC(). Yes, it's best not to deviate contrib code too much from original or we end up with a fork which is difficult to impossible to merge upstream into. Someone had suggested this very thing previously. Gleb (glebius) and I objected. > > Reported by: jhb > Reviewed by: cy, imp, markj, rmacklem > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D14035 > > Modified: > head/sys/contrib/ipfilter/netinet/ip_compat.h > head/sys/fs/nfs/nfs_commonkrpc.c > head/sys/fs/nfs/nfs_commonsubs.c > head/sys/fs/nfs/nfsport.h > head/sys/fs/nfsclient/nfs_clcomsubs.c > head/sys/fs/nfsclient/nfs_clnode.c > head/sys/fs/nfsclient/nfs_clport.c > head/sys/fs/nfsclient/nfs_clrpcops.c > head/sys/fs/nfsclient/nfs_clstate.c > head/sys/fs/nfsclient/nfs_clsubs.c > head/sys/fs/nfsclient/nfs_clvfsops.c > head/sys/fs/nfsclient/nfs_clvnops.c > head/sys/fs/nfsclient/nfsnode.h > head/sys/fs/nfsserver/nfs_nfsdcache.c > head/sys/fs/nfsserver/nfs_nfsdport.c > head/sys/fs/nfsserver/nfs_nfsdserv.c > head/sys/fs/nfsserver/nfs_nfsdstate.c > head/sys/netinet/ip_mroute.c > head/sys/nfsclient/nfsnode.h > head/sys/sys/malloc.h > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.