From owner-freebsd-current@freebsd.org Wed Jul 1 21:32:47 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FC4B9920E2 for ; Wed, 1 Jul 2015 21:32:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E5E432B88 for ; Wed, 1 Jul 2015 21:32:46 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t61LWfmh000961 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 2 Jul 2015 00:32:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t61LWfmh000961 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t61LWfeR000960; Thu, 2 Jul 2015 00:32:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 2 Jul 2015 00:32:41 +0300 From: Konstantin Belousov To: Ryan Stone Cc: Jack Vogel , FreeBSD Current Subject: Re: How should a driver shutdown a taskqueue on detach? Message-ID: <20150701213241.GG2080@kib.kiev.ua> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2015 21:32:47 -0000 On Wed, Jul 01, 2015 at 05:09:27PM -0400, Ryan Stone wrote: > On Wed, Jul 1, 2015 at 4:58 PM, Jack Vogel wrote: > > > But if you've disabled interrupts why would an "interrupt-handling task" > > even run?? > > > > Jack > > > > There's a race. The task could have already have been scheduled by a > previous interrupt and could be running while I am trying to disable > interrupts and drain the taskqueue. Do you mean, you want some KPI like boolean taskqueue_is_draining(struct taskqueue *p); so that e.g. executed task could see if it is executing in the shutdown state ?