Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 Sep 2001 03:52:35 -0700
From:      Dima Dorfman <dima@unixfreak.org>
To:        Matt Dillon <dillon@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libatm atm_addr.c cache_key.c ioctl_subr.c ip_addr.c ip_checksum.c timer.c 
Message-ID:  <20010915105240.F28023E28@bazooka.unixfreak.org>
In-Reply-To: <200109150342.f8F3gBs64706@freefall.freebsd.org>; from dillon@FreeBSD.org on "Fri, 14 Sep 2001 20:42:10 -0700 (PDT)"

next in thread | previous in thread | raw e-mail | index | archive | help
Matt Dillon <dillon@FreeBSD.org> wrote:
> dillon      2001/09/14 20:42:10 PDT
> 
>   Modified files:
>     lib/libatm           atm_addr.c cache_key.c ioctl_subr.c 
>                          ip_addr.c ip_checksum.c timer.c 
>   Log:
>   Convert a library to use the new __FBSDID()'s for testing and review
>   purposes.
...
> Index: src/lib/libatm/timer.c
> diff -u src/lib/libatm/timer.c:1.3 src/lib/libatm/timer.c:1.4
> --- src/lib/libatm/timer.c:1.3	Fri Aug 27 16:58:05 1999
> +++ src/lib/libatm/timer.c	Fri Sep 14 20:42:10 2001
> @@ -36,6 +36,7 @@
>   */
>  
>  #include <sys/types.h>
> +#include <sys/cdefs.h>
>  #include <sys/param.h>
>  #include <sys/socket.h>
>  #include <net/if.h>

I think this part is wrong, or at least unnecessary.  "<sys/types.h>
includes <sys/cdefs.h>, and it's okay to depend on that," says style(9).

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010915105240.F28023E28>