Date: Fri, 15 Jul 2016 05:19:31 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Conrad E. Meyer" <cem@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r418513 - in head/devel: . dwarves dwarves/files Message-ID: <20160715051931.GA5739@FreeBSD.org> In-Reply-To: <201607140531.u6E5VkSG041584@repo.freebsd.org> References: <201607140531.u6E5VkSG041584@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 14, 2016 at 05:31:46AM +0000, Conrad E. Meyer wrote: > New Revision: 418513 > URL: https://svnweb.freebsd.org/changeset/ports/418513 > > Log: > New port: devel/dwarves > > [...] > +MAINTAINER= cem@FreeBSD.org > +COMMENT= Debugging Information Manipulation Tools COMMENT is not a formal title and thus only the first word should be capitalized in this case. > +LICENSE= GPLv2 > +LICENSE_FILE_GPLv2= $(WRKSRC)/COPYING Just `LICENSE_FILE' would be sufficient. Also, style bug: we use curly braces in ports' makefiles, not round ones (also below). > +#CMAKE_VERBOSE= 1 [Comment removed in r418516.] CMAKE_VERBOSE is set for unattended/package builds in `Mk/Uses/cmake.mk', so it can be removed from here, as individual users might have their own preference when building ports by themselves. > +post-patch: > + @${CP} -a \ > + $(LOCALBASE)/share/gnulib/lib/gettext.h \ > + $(LOCALBASE)/share/gnulib/lib/obstack.c \ > + $(LOCALBASE)/share/gnulib/lib/obstack.h \ Bogus brace style again. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160715051931.GA5739>