From owner-svn-ports-head@freebsd.org  Fri Jul 15 05:19:31 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4236BB990CE;
 Fri, 15 Jul 2016 05:19:31 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 382191F50;
 Fri, 15 Jul 2016 05:19:31 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 36C8C114E; Fri, 15 Jul 2016 05:19:31 +0000 (UTC)
Date: Fri, 15 Jul 2016 05:19:31 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "Conrad E. Meyer" <cem@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r418513 - in head/devel: . dwarves dwarves/files
Message-ID: <20160715051931.GA5739@FreeBSD.org>
References: <201607140531.u6E5VkSG041584@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201607140531.u6E5VkSG041584@repo.freebsd.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jul 2016 05:19:31 -0000

On Thu, Jul 14, 2016 at 05:31:46AM +0000, Conrad E. Meyer wrote:
> New Revision: 418513
> URL: https://svnweb.freebsd.org/changeset/ports/418513
> 
> Log:
>   New port: devel/dwarves
> 
> [...]
> +MAINTAINER=	cem@FreeBSD.org
> +COMMENT=	Debugging Information Manipulation Tools

COMMENT is not a formal title and thus only the first word should be
capitalized in this case.

> +LICENSE=	GPLv2
> +LICENSE_FILE_GPLv2=	$(WRKSRC)/COPYING

Just `LICENSE_FILE' would be sufficient.  Also, style bug: we use curly
braces in ports' makefiles, not round ones (also below).

> +#CMAKE_VERBOSE=	1

[Comment removed in r418516.]  CMAKE_VERBOSE is set for unattended/package
builds in `Mk/Uses/cmake.mk', so it can be removed from here, as individual
users might have their own preference when building ports by themselves.

> +post-patch:
> +	@${CP} -a \
> +	    $(LOCALBASE)/share/gnulib/lib/gettext.h \
> +	    $(LOCALBASE)/share/gnulib/lib/obstack.c \
> +	    $(LOCALBASE)/share/gnulib/lib/obstack.h \

Bogus brace style again.

./danfe