From owner-freebsd-fs@FreeBSD.ORG Thu Jan 20 13:11:50 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A7DD106564A for ; Thu, 20 Jan 2011 13:11:50 +0000 (UTC) (envelope-from gleb.kurtsou@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 903068FC13 for ; Thu, 20 Jan 2011 13:11:49 +0000 (UTC) Received: by fxm16 with SMTP id 16so586923fxm.13 for ; Thu, 20 Jan 2011 05:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=//kHEesk4WocBhk742DglXc7OZo3TtdhJpoGWQRNgNw=; b=g4ymA2fP0XFJwxrIJ/RZyJhnG7rmEmXpwiWU5o24z+1EbUsG521tGnP+Ypf7HMSkD5 a8I3wNJ0H2w/sxPLcVrpbIW3QzxdVvj9wKin6QRtGjBvzdvFRV8oXgGz12ueVFUW36dp y5L5DocWESRQMbhmQvIQDindtBqo0+j30foPc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=KaVLA3ZWwCbH8tHRqQB4MeQ3VrBDfScH2+vXPtzeIIYyqemwYiFFAOOrxVGX9rFiTo dumwEva0+QcM0xC5p7LmhunWQ332F21MxU+qYGcc6s87283pKYv/Kf0JAJmiowu19hDN +PNrH7/4Fchws25Rbk8+vADTMEGnvtYdXBLXc= Received: by 10.223.95.202 with SMTP id e10mr2050359fan.32.1295527295387; Thu, 20 Jan 2011 04:41:35 -0800 (PST) Received: from localhost (lan-78-157-92-5.vln.skynet.lt [78.157.92.5]) by mx.google.com with ESMTPS id r24sm3096246fax.27.2011.01.20.04.41.33 (version=SSLv3 cipher=RC4-MD5); Thu, 20 Jan 2011 04:41:34 -0800 (PST) Date: Thu, 20 Jan 2011 14:41:08 +0200 From: Gleb Kurtsou To: Kostik Belousov Message-ID: <20110120124108.GA32866@tops.skynet.lt> References: <20101201091203.GA3933@tops> <20110104175558.GR3140@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20110104175558.GR3140@deviant.kiev.zoral.com.ua> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-fs@freebsd.org Subject: Re: [rfc] 64-bit inode numbers X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jan 2011 13:11:50 -0000 I've updated the patch. New version is available here: https://github.com/downloads/glk/freebsd-ino64/freebsd-ino64-patch-2011-01-20.tgz Changelog: * Add fts, ftw, nftw compat shims in libc * Place libc compat shims in separate files, don't hack original implementations. * Fix dump/restore * Use ino_t in UFS code (suggested by Kirk McKusick) * Keep ufs_ino_t (32 bit) for boot2 not to increase size On (04/01/2011 19:55), Kostik Belousov wrote: > I think some more comments for each patch in the set, in addition to > the one-line title, would be useful. > > No need to add regen patches, they only confuse the reader. Just add a > note to other patches where the regen is needed. > > I have big doubts about 0009, since struct inoref is not on-disk struct. Thanks. > My impression is that the issue of extending ino_t to 64 bit is much bigger > then presented in your patch. E.g. FTSENT (include/fts.h) explicitely > include ino_t member. As result, there are more ABI changes that handled. > Or, did I missed this in the patchset ? I've missed this one, and also ftw/nftw. > Might be, libarchive and libufs are also affected. Not sure about struct > pidfh from libutil. There is no symbol versioning in these libraries, SHLIB_MAJOR should be dumped (for all libraries in the tree). Thanks, Gleb.