From owner-cvs-all  Fri Sep  7  9:39:56 2001
Delivered-To: cvs-all@freebsd.org
Received: from peace.mahoroba.org (peace.calm.imasy.or.jp [202.227.26.34])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2FBF537B401; Fri,  7 Sep 2001 09:39:44 -0700 (PDT)
Received: from localhost (IDENT:ODYkAFz2usTbplgJrRJzl9A9kiAXYNFgJLSXjajfOnS0a1Q4W+v2G+Q7iv2x0vMP@localhost [::1])
	(authenticated as ume with CRAM-MD5)
	by peace.mahoroba.org (8.11.6/8.11.6/peace) with ESMTP/inet6 id f87GdiF53021;
	Sat, 8 Sep 2001 01:39:44 +0900 (JST)
	(envelope-from ume@mahoroba.org)
Date: Sat, 08 Sep 2001 01:39:41 +0900 (JST)
Message-Id: <20010908.013941.59479858.ume@mahoroba.org>
To: markm@FreeBSD.org
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/su Makefile su.c
From: Hajimu UMEMOTO <ume@mahoroba.org>
In-Reply-To: <200109071620.f87GKcD95183@freefall.freebsd.org>
References: <200109071620.f87GKcD95183@freefall.freebsd.org>
X-Mailer: xcite1.38> Mew version 1.95b119 on Emacs 20.7 / Mule 4.0
 =?iso-2022-jp?B?KBskQjJWMWMbKEIp?=
X-PGP-Public-Key: http://www.imasy.org/~ume/publickey.asc
X-PGP-Fingerprint: 6B 0C 53 FC 5D D0 37 91  05 D0 B3 EF 36 9B 6A BC
X-URL: http://www.imasy.org/~ume/
X-Operating-System: FreeBSD 5.0-CURRENT
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Hi,

>>>>> On Fri, 7 Sep 2001 09:20:38 -0700 (PDT)
>>>>> Mark Murray <markm@FreeBSD.org> said:

markm> markm       2001/09/07 09:20:38 PDT

markm>   Modified files:
markm>     usr.bin/su           Makefile su.c 
markm>   Log:
markm>   Back out (with prejudice) the last WARNS=2 fix. I cannot understand
markm>   its failure mode, and will revisit it later.
  
If you mean `su user -c command' breakage, this patch fixes it:

Index: usr.bin/su/su.c
diff -u usr.bin/su/su.c.orig usr.bin/su/su.c
--- usr.bin/su/su.c.orig	Fri Sep  7 18:21:44 2001
+++ usr.bin/su/su.c	Fri Sep  7 18:24:18 2001
@@ -116,7 +116,7 @@
 	login_cap_t	*lc;
 	union {
 		const char	**a;
-		char		* const b[1];
+		char		* const *b;
 	} 		np;
 	uid_t		ruid;
 	gid_t		gid;

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org  ume@bisd.hitachi.co.jp  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message