From owner-svn-src-all@FreeBSD.ORG Thu Oct 2 20:06:26 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9B7D9D8F; Thu, 2 Oct 2014 20:06:26 +0000 (UTC) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.allbsd.org", Issuer "RapidSSL CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 98939AB0; Thu, 2 Oct 2014 20:06:25 +0000 (UTC) Received: from alph.d.allbsd.org ([IPv6:2001:2f0:104:e010:862b:2bff:febc:8956]) (authenticated bits=56) by mail.allbsd.org (8.14.9/8.14.8) with ESMTP id s92K5xZC049848 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 3 Oct 2014 05:06:10 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.8/8.14.8) with ESMTP id s92K5wcg023009; Fri, 3 Oct 2014 05:05:59 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Fri, 03 Oct 2014 05:05:52 +0900 (JST) Message-Id: <20141003.050552.130574284942561369.hrs@allbsd.org> To: dumbbell@FreeBSD.org Subject: Re: svn commit: r272386 - in head: sbin/ifconfig share/man/man4 sys/net From: Hiroki Sato In-Reply-To: <542D9AED.6060805@FreeBSD.org> References: <201410012137.s91LbXL4025967@svn.freebsd.org> <542D9AED.6060805@FreeBSD.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.6 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Fri_Oct__3_05_05_52_2014_877)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mail.allbsd.org [IPv6:2001:2f0:104:e001::32]); Fri, 03 Oct 2014 05:06:13 +0900 (JST) X-Spam-Status: No, score=-97.3 required=13.0 tests=CONTENT_TYPE_PRESENT, MIMEQENC,QENCPTR1,QENCPTR2,RDNS_NONE,SPF_SOFTFAIL,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Oct 2014 20:06:26 -0000 ----Security_Multipart(Fri_Oct__3_05_05_52_2014_877)-- Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Jean-S=E9bastien P=E9dron wrote in <542D9AED.6060805@FreeBSD.org>: du> > Author: hrs du> > Date: Wed Oct 1 21:37:32 2014 du> > New Revision: 272386 du> > URL: https://svnweb.freebsd.org/changeset/base/272386 du> > = du> > Log: du> > Virtualize lagg(4) cloner. This change fixes a panic when tear= ing down du> > if_lagg(4) interfaces which were cloned in a vnet jail. du> = du> Hi! du> = du> I believe this change needs at least an entry in UPDATING, because = an du> ifconfig(8) binary built before this commit fails to change laggpro= to on du> a kernel including this commit. du> = du> The error is the following: du> # ifconfig lagg0 laggproto failover du> ifconfig: SIOCSLAGG: Invalid argument du> = du> By quickly looking at the code, I would say that the culprit is the= du> change in size of the "struct lag_reqall". The new "ra_opts" field = in du> "struct lagg_reqall" isn't initialized in the incompatible ifconfig= (8) du> binary. This could be considered invalid options, leading to "error= =3D du> EINVAL" in if_lagg.c:1301. du> = du> Another non-critical regression is that this ifconfig(8) binary doe= sn't du> display the laggproto and laggport lines. I mean those lines: du> # ifconfig lagg0 du> lagg0: flags=3D8843 (..= .) du> (...) du> laggproto failover lagghash l2,l3,l4 du> laggport: wlan0 flags=3D0<> du> laggport: re0 flags=3D5 du> = du> Beside an UPDATING entry, how about a previously released world wit= h du> this new kernel? Isn't this configuration supposed to work? Ah, yes, I was lazy and did not keep the compatibility. On or after r272446 an old ifconfig works with the new kernel. -- Hiroki ----Security_Multipart(Fri_Oct__3_05_05_52_2014_877)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlQtsCAACgkQTyzT2CeTzy2zLACeP1+8fSGbBvGQX19z/7cYX1pV OU0An2VXcxOGpxjqPTCoZ7nUYxnAQeae =VZyS -----END PGP SIGNATURE----- ----Security_Multipart(Fri_Oct__3_05_05_52_2014_877)----