From owner-svn-src-head@freebsd.org Fri Jun 10 14:15:03 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65F3DB70B9A for ; Fri, 10 Jun 2016 14:15:03 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm2-vm1.bullet.mail.bf1.yahoo.com (nm2-vm1.bullet.mail.bf1.yahoo.com [98.139.213.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1F50B1515 for ; Fri, 10 Jun 2016 14:15:03 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1465568095; bh=haPbNIrR1VsQGjTPo+wPrqmrITcHB4fm7vlr8stJ9W8=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=XSOlmQCOfyI8urLgQyEnadQ5+LE2mnIaDU5UKs540i9FvADvunAmehwVz7VSJylgFaLffRxCY7ZTUL1E2/Ez7776J72LrH7QsBJiAl68oNy3LU1cRGHpeiS7X+ytEoBzBhf7GANQ/GOP7I0B9NmisLU809Sfk04kA0EkYas4FmylOwBnk93muHirLWJNDT+jUYX3D7hyBKlJlE2gdNSkzEpQl+75AfYEIVG6/PdAQkL3BOWoQ2uzLps5NQRwpJk/8nS1F7Lwds2RahBihUQHP2yRcuuErXPAtenC7H1pUZYWia8ExilS4Z4VCB014DZtf3yeB2lzuHBpcIIP224YOg== Received: from [98.139.170.179] by nm2.bullet.mail.bf1.yahoo.com with NNFMP; 10 Jun 2016 14:14:55 -0000 Received: from [68.142.230.72] by tm22.bullet.mail.bf1.yahoo.com with NNFMP; 10 Jun 2016 14:14:55 -0000 Received: from [127.0.0.1] by smtp229.mail.bf1.yahoo.com with NNFMP; 10 Jun 2016 14:14:55 -0000 X-Yahoo-Newman-Id: 770678.50321.bm@smtp229.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 6QT39HUVM1mRkKm8KtpKAYS9_kSua.iiipgkJVHhJYngAYL WIoe6EcQbzgH2F.idyAicBCNqcVbeMrCU_mn6aiSOhRP_99ydbi_rAbzAHtK siKSfu3dptN21uVGWBCzZ55B7_b1IX80LR5q3rH_97FfmpMal5FbkW0dMpQ3 2n1G9GRQkAYjuZNZ0onW27kSfdXfH7m9boXN5INLWPyfTkZJ6ISb34qY22vL hcq1_FtDt9cstIX58m7imzG9OuTLpjf.rzbJAAP2NnA.ckuvfIXp2OAwMI.X onFTSZfIdoIwNevY_BHCHSyE3VI2ItM.8XUCL0uIC4Ucsd27XAoIMm_BNIOc R6XHm5iNBC2icLUoeoQA4E_UefAU95CnLPgg0nWc4NQtGvs8X7JaMw9iz6Qh pgIfobWdFaTCNdin6Uclr4UvTrFTlNj3WkJiq_F_cIoQCq13wgJ.4Q.YSA00 GFMdb2iX.1qkJfMp.QZ3RN2hvyJ46AxQNfjRGoKqNXk9cR6Jdyp1K8HJFI0Z zdCkWsl7H9_dSV7THLMzCvaoMYL8jsuDf X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r301777 - head/lib/libc/stdio To: Andrey Chernov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201606100521.u5A5Lqa6035072@repo.freebsd.org> <3346cab5-d713-c1ad-5e50-ea8d50ee47b9@freebsd.org> <52d3a4b3-0b52-abd3-8633-909885f12781@freebsd.org> From: Pedro Giffuni Message-ID: <03897eab-0725-7c7a-0edf-04eb44eff6f7@FreeBSD.org> Date: Fri, 10 Jun 2016 09:14:55 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <52d3a4b3-0b52-abd3-8633-909885f12781@freebsd.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2016 14:15:03 -0000 On 06/10/16 07:19, Andrey Chernov wrote: > On 10.06.2016 15:03, Pedro Giffuni wrote: >> (Sorry I have been offline/sleep for a while) >> >> Hello; >> >> I cannot back this out because of this report: >> >> http://docs.freebsd.org/cgi/mid.cgi?20160608132224.GA15454 >> >> This change only re-states what has been working before the ABI breakage >> fix in r301461. > > Because now strcoll_l() is used as before and it is broken in wide char > converting process. It is broken for _all_, not just for vfscanf() > ranges. It should never fail with any args. > Real fix should be in strcoll_l(). > Yes, it is broken as before however the objective of r301461 was only to address the ABI breakage. If I revert r301777 then I have to backout r301461 too, and then we have again the ABI breakage. I understand you want to fix all but we are under code freeze and I have to go back to a known working (although still broken) state. >> The fix to regex is completely independent. > > It is dependent. vfscanf() and regcomp() use the same code for range > collation. If we remove range collation from everywhere, we save > vfscanf(), but strcoll_l() remains broken. > > We have had a broken regex for a very long time, and we new that before collation was introduced. I didn't take that decision but moving to libtre was a lot more work and we really had to have collation now. Pedro.