Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Nov 2014 09:33:38 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Marcelo Araujo <araujo@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r373395 - in head/www/youtube_dl: . files
Message-ID:  <20141125093338.GA58904@FreeBSD.org>
In-Reply-To: <201411250823.sAP8N5O7016231@svn.freebsd.org>
References:  <201411250823.sAP8N5O7016231@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 25, 2014 at 08:23:05AM +0000, Marcelo Araujo wrote:
> New Revision: 373395
> URL: https://svnweb.freebsd.org/changeset/ports/373395
> QAT: https://qat.redports.org/buildarchive/r373395/
> 
> [...]
> @@ -1,6 +1,6 @@
> ---- youtube_dl/__init__.py.orig	2014-09-27 21:51:19 UTC
> -+++ youtube_dl/__init__.py
> -@@ -108,7 +108,6 @@
> +--- youtube_dl/__init__.py.orig	2014-11-23 17:50:21.000000000 +0800
> ++++ youtube_dl/__init__.py	2014-11-23 21:17:37.918929006 +0800
> +@@ -34,7 +34,6 @@

Please avoid this; notice that previous version contained UTC-normalized
mtime of the original file only: this helps to keep the diff noize lower.

Generally I recommend trimming touching patch headers completely (if they
are otherwise functionally fine).

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141125093338.GA58904>