From owner-freebsd-arm@FreeBSD.ORG Thu May 2 15:24:05 2013 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 875F6B74; Thu, 2 May 2013 15:24:05 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109]) by mx1.freebsd.org (Postfix) with ESMTP id 3AB05133D; Thu, 2 May 2013 15:24:05 +0000 (UTC) Received: from localhost (unknown [213.17.239.109]) by smtp.semihalf.com (Postfix) with ESMTP id 469C6D4C8F; Thu, 2 May 2013 17:24:04 +0200 (CEST) X-Virus-Scanned: by amavisd-new at semihalf.com Received: from smtp.semihalf.com ([213.17.239.109]) by localhost (smtp.semihalf.com [213.17.239.109]) (amavisd-new, port 10024) with ESMTP id ukndJudYkgvE; Thu, 2 May 2013 17:24:03 +0200 (CEST) Received: from [10.0.2.117] (cardhu.semihalf.com [213.17.239.108]) by smtp.semihalf.com (Postfix) with ESMTPSA id A3B29D4C7C; Thu, 2 May 2013 17:24:03 +0200 (CEST) Message-ID: <51828513.9000406@semihalf.com> Date: Thu, 02 May 2013 17:24:03 +0200 From: Zbyszek Bodek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Ian Lepore Subject: Re: RFC: Patches with AXP support and pmap&smp fixes. References: <517E8610.5050204@semihalf.com> <1367338875.1180.44.camel@revolution.hippie.lan> In-Reply-To: <1367338875.1180.44.camel@revolution.hippie.lan> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-arm@FreeBSD.org X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2013 15:24:05 -0000 On 30.04.2013 18:21, Ian Lepore wrote: > On Mon, 2013-04-29 at 16:39 +0200, Grzegorz Bernacki wrote: >> Hi, >> >> I am going to submit some changes related to Armada XP support and some >> general ARM fixes. You can find them at: >> http://people.freebsd.org/~gber/armada >> >> It would be good if someone could review changes in generic ARM code i.e.: >> 1) >> http://people.freebsd.org/~gber/armada/0004-arm-smp-Fix-AP-processors-initialization-procedure.patch >> >> This patch fixes race condition in pcpu_init function. pcpu_init >> performs operation on signly-linked tail queue and the queue can be >> corrupted by secondary cpus initialization. >> >> 2) >> http://people.freebsd.org/~gber/armada/0007-arm-Fix-L2-PTE-access-permissions-management.patch >> http://people.freebsd.org/~gber/armada/0008-arm-Fix-page-reference-emulation-on-ARMv6-and-v7.patch >> >> These are changes which fixes reference simulation and access >> permissions in pmap v6. >> >> It would be great if you could also review armada patches. >> We will appreciate all comments and remarks. If there will be no >> objections I am going to submit these changes at the beginning of the >> next week. >> >> thanks, >> greg > > I've reviewed them, and see no problems. It might not be a bad idea to > paste the protections truth table from the commit message as a comment > block in pmap_set_prot(); I had to keep referring to it while convincing > myself the changes were right for every path through the routine. > > -- Ian > Hello Ian, Sure, we will add suggested comment to the code. But would it not be better to place it in the pmap.h file just before L2_S_PROT_R, L2_S_PROT_U, etc. definitions. Please notice that the similar to pmap_set_prot() protections setting sequence is also used in pmap_enter_locked(). What is your opinion? Best regards Zbyszek Bodek