From owner-svn-src-all@freebsd.org  Wed Mar 21 21:54:15 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7D63F6AA45;
 Wed, 21 Mar 2018 21:54:15 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 452306A956;
 Wed, 21 Mar 2018 21:54:15 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.128.70])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 0659526061A;
 Wed, 21 Mar 2018 22:54:12 +0100 (CET)
Subject: Re: svn commit: r331306 - head/sys/dev/usb/controller
To: Andrew Turner <andrew@fubar.geek.nz>
Cc: Kyle Evans <kevans@freebsd.org>,
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201803211517.w2LFHsHf007714@repo.freebsd.org>
 <CACNAnaHCf8paMB3RP1SSnP45xPTSKEcJp-qKyKievLE0E_svWA@mail.gmail.com>
 <b8627a61-adde-a9b4-8cd1-af9435b9ea92@selasky.org>
 <898DF1A6-F1D2-474C-92B5-12F65DC71A40@fubar.geek.nz>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <00c43a84-893e-cbd8-ff6d-f7a551ae3beb@selasky.org>
Date: Wed, 21 Mar 2018 22:54:08 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <898DF1A6-F1D2-474C-92B5-12F65DC71A40@fubar.geek.nz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Mar 2018 21:54:15 -0000

On 03/21/18 17:45, Andrew Turner wrote:
> 
> 
>> On 21 Mar 2018, at 15:37, Hans Petter Selasky <hps@selasky.org> wrote:
>>
>> On 03/21/18 16:24, Kyle Evans wrote:
>>>> +       {
>>>> +               .ep_end = 7,
>>>> +               .ep_fifosz_shift = 9,
>>>> +               .ep_fifosz_reg = MUSB2_VAL_FIFOSZ_512 | MUSB2_MASK_FIFODB,
>>>> +       },
>>> I'm afraid I'm not familiar with this- why did .ep_fifosz_shift for
>>> this case drop to 9? frx = 10 in the temp < 8 case in the removals of
>>> the following hunks. Mostly curious because the others seemed to stay
>>> the same.
>>
>> Hi Andrew,
>>
>> It might be an idea to keep the fifosz_shift at 10, else high-speed BULK traffic won't be double buffered, and this might affect performance.
> 
> Should the endpoint 1 size also be fixed? The register has it at 4k, but it wasn’t an 8k buffer.
> 

No, because High-Speed BULK will only use 512 byte packets, and 4k is 
reserved for isochronous, which doesn't need double buffering at the moment.

--HPS