Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Jun 2018 15:12:20 +0000 (UTC)
From:      Justin Hibbits <jhibbits@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r334716 - head/sys/kern
Message-ID:  <201806061512.w56FCKgf057289@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jhibbits
Date: Wed Jun  6 15:12:19 2018
New Revision: 334716
URL: https://svnweb.freebsd.org/changeset/base/334716

Log:
  Revert r334708
  
  This is the wrong place to put the barrier.
  Requested by:	kib,mjg

Modified:
  head/sys/kern/vfs_subr.c

Modified: head/sys/kern/vfs_subr.c
==============================================================================
--- head/sys/kern/vfs_subr.c	Wed Jun  6 15:10:11 2018	(r334715)
+++ head/sys/kern/vfs_subr.c	Wed Jun  6 15:12:19 2018	(r334716)
@@ -2807,9 +2807,6 @@ _vhold(struct vnode *vp, bool locked)
 	CTR2(KTR_VFS, "%s: vp %p", __func__, vp);
 	if (!locked) {
 		if (refcount_acquire_if_not_zero(&vp->v_holdcnt)) {
-#if !defined(__amd64__) && !defined(__i386__)
-			mb();
-#endif
 			VNASSERT((vp->v_iflag & VI_FREE) == 0, vp,
 			    ("_vhold: vnode with holdcnt is free"));
 			return;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806061512.w56FCKgf057289>