From owner-svn-ports-head@FreeBSD.ORG Wed Jun 17 16:50:42 2015 Return-Path: Delivered-To: svn-ports-head@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CA814E58; Wed, 17 Jun 2015 16:50:42 +0000 (UTC) (envelope-from swills@mouf.net) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8924DFB1; Wed, 17 Jun 2015 16:50:42 +0000 (UTC) (envelope-from swills@mouf.net) Received: from mouf.net (swills@mouf [199.48.129.64]) by mouf.net (8.14.9/8.14.9) with ESMTP id t5HGoWdu048193 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 17 Jun 2015 16:50:37 GMT (envelope-from swills@mouf.net) Received: (from swills@localhost) by mouf.net (8.14.9/8.14.9/Submit) id t5HGoWrE048191; Wed, 17 Jun 2015 16:50:32 GMT (envelope-from swills) Date: Wed, 17 Jun 2015 16:50:31 +0000 From: Steve Wills To: Adam Weinberger Cc: Brad Davis , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r389861 - in head/devel: cmake cmake-gui cmake-modules Message-ID: <20150617165030.GA48147@mouf.net> References: <201506162025.t5GKP6lx080770@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Wed, 17 Jun 2015 16:50:37 +0000 (UTC) X-Spam-Status: No, score=0.0 required=4.5 tests=HEADER_FROM_DIFFERENT_DOMAINS autolearn=unavailable autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.98.7 at mouf.net X-Virus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 16:50:42 -0000 On Wed, Jun 17, 2015 at 09:39:11AM -0600, Adam Weinberger wrote: > > On 16 Jun, 2015, at 14:25, Brad Davis wrote: > > > > Author: brd > > Date: Tue Jun 16 20:25:05 2015 > > New Revision: 389861 > > URL: https://svnweb.freebsd.org/changeset/ports/389861 > > > > Log: > > Update devel/cmake, devel/cmake-gui and devel/cmake-modules to 3.2.3. > > > > Modified: head/devel/cmake/Makefile > > ============================================================================== > > > > LIB_DEPENDS= libcurl.so:${PORTSDIR}/ftp/curl \ > > - libexpat.so:${PORTSDIR}/textproc/expat2 > > + libexpat.so:${PORTSDIR}/textproc/expat2 \ > > + libjsoncpp.so:${PORTSDIR}/devel/jsoncpp > > Does this port really need to depend on libjsoncpp? The version bundled with cmake works just fine (--no-system-jsoncpp). > > The only benefit to making everybody install jsoncpp (and scons) would be if the jsoncpp port is updated more often than the cmake port. But the jsoncpp port hasn't had an update since the day it was added 16 months ago. > > Can you please consider dropping the libjsoncpp dependency and just adding --no-system-jsoncpp to CONFIGURE_ARGS? > In general, it is better to not used bundled libs where possible. Let's update the devel/jsoncpp port. Steve