From owner-svn-src-head@freebsd.org  Sun Mar 12 09:32:32 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7C40D07FC2;
 Sun, 12 Mar 2017 09:32:32 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id ACDAB1611;
 Sun, 12 Mar 2017 09:32:31 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA25952;
 Sun, 12 Mar 2017 11:32:28 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1cmzrY-000MIC-3j; Sun, 12 Mar 2017 11:32:28 +0200
Subject: Re: svn commit: r315068 - head/sys/modules/qlxgbe
To: Bruce Evans <brde@optusnet.com.au>
References: <201703111516.v2BFGtkn006959@repo.freebsd.org>
 <20170312124945.C4483@besplex.bde.org>
Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
 svn-src-head@FreeBSD.org
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <18e52ee7-0b27-7aff-6b69-75b27673a8f4@FreeBSD.org>
Date: Sun, 12 Mar 2017 11:31:31 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20170312124945.C4483@besplex.bde.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Mar 2017 09:32:32 -0000

On 12/03/2017 04:44, Bruce Evans wrote:
> On Sat, 11 Mar 2017, Andriy Gapon wrote:
> 
>> Log:
>>  revert r314862, use of GCC_MS_EXTENSIONS in qlxgbe
>>
>>  Commit r278913 made explicit use of GCC_MS_EXTENSIONS  unnecessary.
>>
>>  Requested by:    glebius
> 
> Does this module actually use ms extensions?  This seems unlikely, since
> only gcc supports them.

It probably doesn't.

> My kernels compile correctly with the correct CFLAGS (gcc -std=gnu99
> -fno-ms-extensions).

How did you manage to pass -std=gnu99 to the module build?
No matter what flags I tried to modify the actual compiler invocations still had
-std=iso9899:1999 after -std=gnu99 in them, so my modifications had no effect.
GCC_MS_EXTENSIONS was the easiest way to get the job done.

-- 
Andriy Gapon