Date: Fri, 20 Nov 2015 09:49:28 +0100 From: =?UTF-8?Q?Torsten_Z=c3=bchlsdorff?= <mailinglists@toco-domains.de> To: Ricky G <ricky1252@hotmail.com>, Craig Rodrigues <rodrigc@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, "freebsd-ports@freebsd.org" <freebsd-ports@freebsd.org> Subject: Re: Call for Help: need script for patching ports tree, building with poudriere Message-ID: <564EDE98.9070508@toco-domains.de> In-Reply-To: <SNT146-W629FAF58F79486179755FEA1100@phx.gbl> References: <CAG=rPVcOb4g9DD08c7vAsor8UMf3GnckAJ2wkO37p8Ao3G2GwA@mail.gmail.com> <SNT146-W8224851E20D3E1FDA17AD4A1150@phx.gbl> <CAG=rPVfZV4kZbhG5c-%2BrjFG4vGTzMmrRasSyBQ%2BgCtY8FBEtoA@mail.gmail.com> <SNT146-W629FAF58F79486179755FEA1100@phx.gbl>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello Ricky,
> Hello, Decided to not add a config file to keep it simpler, so you'll
> need to edit the variables to your needs below the options. The only
> packages that it may need is portlint, porttools and/or poudriere.
> Let me know what you think or needs improvement.
Thank you very much for your script!
I took a short look at it and have some questions/suggestions:
Line 119/120:
There you're burning an if. I have more skill in bash than in sh - but
is there no negation possible?
Line 162:
BUILD_LIST="`(cat ${PATCH_FILE} | grep -o '^Index:[ ].*' | sed 's/Index:
// ; s/Mk.*// ; s/Tools.*// ; s/Templates.*// ; s/Keywords.*//' | grep
-o -e '.*\/.*\/' | sed 's/.*\/.*\/files\/$// ; s/\/$//' | sort | awk
'!a[$0]++')`"
This line is relative complicated. Is there any reason not to let svn do
the work? Like:
BUILD_LIST="`${SVN} status | grep -o -e '.*\/.*\/' | awk '{ print $2 }'`
Your way is faster (and more accurate, since i'm currently too short on
time), but the other way would allow applying multiple patches and
manual changes without any problems. But i'm not sure if this is really
needed.
Line 201:
svn revert -R would do the same, both of our approaches have a problem:
the ignore for example added files.
Greetings,
Torsten
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?564EDE98.9070508>