Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Jan 2015 17:23:18 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Hans Petter Selasky <hps@selasky.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, sbruno@freebsd.org, John Baldwin <jhb@FreeBSD.org>
Subject:   Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys
Message-ID:  <20150115172318.GA86401@FreeBSD.org>
In-Reply-To: <54B7E566.8050601@selasky.org>
References:  <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54B7E287.80406@FreeBSD.org> <54B7E566.8050601@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 15, 2015 at 05:05:58PM +0100, Hans Petter Selasky wrote:
> The "Reviewed by" was simply a C&P of the review list in from the
> Differential Revision. When you mention it should probably simply have said:
> 
> Reviewed by: sbruno @
> 
> Due to the meaning of "Reviewed by" in commit messages. Sorry.
> 
> BTW: Nice if people respond quickly or remove themselves from the
> differential reviews if they don't plan to do any reviews.

I think it's kind of wrong.  Instead, lack of reviews should be treated as
"lack of reviews" (and thus blocking commit), not that "people are not
interested".

./danfe

P.S.  BTW, I still didn't receive your answer on an email I sent Jan 8th.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150115172318.GA86401>