From owner-svn-src-all@FreeBSD.ORG Thu Jan 15 17:23:18 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 3CE22C4; Thu, 15 Jan 2015 17:23:18 +0000 (UTC) Date: Thu, 15 Jan 2015 17:23:18 +0000 From: Alexey Dokuchaev To: Hans Petter Selasky Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys Message-ID: <20150115172318.GA86401@FreeBSD.org> References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54B7E287.80406@FreeBSD.org> <54B7E566.8050601@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54B7E566.8050601@selasky.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, sbruno@freebsd.org, John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2015 17:23:18 -0000 On Thu, Jan 15, 2015 at 05:05:58PM +0100, Hans Petter Selasky wrote: > The "Reviewed by" was simply a C&P of the review list in from the > Differential Revision. When you mention it should probably simply have said: > > Reviewed by: sbruno @ > > Due to the meaning of "Reviewed by" in commit messages. Sorry. > > BTW: Nice if people respond quickly or remove themselves from the > differential reviews if they don't plan to do any reviews. I think it's kind of wrong. Instead, lack of reviews should be treated as "lack of reviews" (and thus blocking commit), not that "people are not interested". ./danfe P.S. BTW, I still didn't receive your answer on an email I sent Jan 8th.