Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Apr 2016 21:45:19 +0000 (UTC)
From:      "Andrey V. Elsukov" <ae@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r298001 - head/sys/netpfil/ipfw
Message-ID:  <201604142145.u3ELjJIm051591@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ae
Date: Thu Apr 14 21:45:18 2016
New Revision: 298001
URL: https://svnweb.freebsd.org/changeset/base/298001

Log:
  Adjust some comments and make ref_opcode_object() static.

Modified:
  head/sys/netpfil/ipfw/ip_fw_sockopt.c

Modified: head/sys/netpfil/ipfw/ip_fw_sockopt.c
==============================================================================
--- head/sys/netpfil/ipfw/ip_fw_sockopt.c	Thu Apr 14 21:31:16 2016	(r298000)
+++ head/sys/netpfil/ipfw/ip_fw_sockopt.c	Thu Apr 14 21:45:18 2016	(r298001)
@@ -2362,12 +2362,11 @@ unref_rule_objects(struct ip_fw_chain *c
  * Find and reference object (if any) stored in instruction @cmd.
  *
  * Saves object info in @pidx, sets
- *  - @found to 1 if object was found and references
  *  - @unresolved to 1 if object should exists but not found
  *
  * Returns non-zero value in case of error.
  */
-int
+static int
 ref_opcode_object(struct ip_fw_chain *ch, ipfw_insn *cmd, struct tid_info *ti,
     struct obj_idx *pidx, int *unresolved)
 {
@@ -2513,7 +2512,7 @@ rewrite_rule_uidx(struct ip_fw_chain *ch
 	 * to reflect actual number of object opcodes.
 	 */
 
-	/* Perform rule rewrite */
+	/* Perform rewrite of remaining opcodes */
 	p = pidx_first;
 	pidx_last = pidx_first + ci->object_opcodes;
 	for (p = pidx_first; p < pidx_last; p++) {
@@ -2994,7 +2993,7 @@ export_objhash_ntlv_internal(struct name
 /*
  * Lists all service objects.
  * Data layout (v0)(current):
- * Request: [ ipfw_obj_lheader ] size = ipfw_cfg_lheader.size
+ * Request: [ ipfw_obj_lheader ] size = ipfw_obj_lheader.size
  * Reply: [ ipfw_obj_lheader [ ipfw_obj_ntlv x N ] (optional) ]
  * Returns 0 on success
  */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604142145.u3ELjJIm051591>