Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 4 Jul 2013 15:58:31 GMT
From:      Rene Ladan <rene@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/180265: astro/celestia: remove KDE3 support
Message-ID:  <201307041558.r64FwVQa087988@oldred.freebsd.org>
Resent-Message-ID: <201307041600.r64G002r089214@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         180265
>Category:       ports
>Synopsis:       astro/celestia: remove KDE3 support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 04 16:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Rene Ladan
>Release:        FreeBSD 9.1-amd64
>Organization:
>Environment:
FreeBSD 9.1-amd64
Ports Tree r322216
>Description:
Remove support for the expired KDE3 port.
While here convert NOPORTDOCS

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 322216)
+++ Makefile	(working copy)
@@ -27,7 +27,7 @@
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib -pthread
 
-UI_LIST=	glut gtk gnome kde
+UI_LIST=	glut gtk gnome
 CELESTIA_UI?=	glut
 CONFLICTS=	${UI_LIST:S|${CELESTIA_UI}||:S|^|celestia-|:S|$|-[0-9]*|}
 
@@ -41,9 +41,10 @@
 # gnome	Full GTK interface plus a few Gnome integration goodies, such as
 #	preference saving in GConf (this looks and works very much like
 #	the Windows interface);
-# kde	Probably the richest of all: brings contextual menus, toolbars,
-#	KDE integration, internationalization, bookmarks, etc.
 #
+
+.include <bsd.port.options.mk>
+
 .if ${CELESTIA_UI} == "glut"
 CONFIGURE_ARGS+=	--with-glut
 USE_GL+=	glut
@@ -55,11 +56,6 @@
 CONFIGURE_ARGS+=	--with-gnome
 USE_GNOME+=	libgnomeui
 GCONF_SCHEMAS=	celestia.schemas
-.elif ${CELESTIA_UI} == "kde"
-CATEGORIES+=	kde
-CONFIGURE_ARGS+=	--with-kde
-USE_KDELIBS_VER=	3
-INSTALLS_ICONS=	yes
 .else
 IGNORE=		requires one of the <${UI_LIST}> values for CELESTIA_UI
 .endif
@@ -73,12 +69,7 @@
 .else
 STARTUP_NOTIFY=	false
 .endif
-.if ${CELESTIA_UI} == "kde"
-LIB_DEPENDS+=	theora:${PORTSDIR}/multimedia/libtheora
-PLIST_SUB+=	KDE=""
-.else
 PLIST_SUB+=	KDE="@comment "
-.endif
 
 PORTDOCS=	AUTHORS ChangeLog README
 
@@ -110,7 +101,7 @@
 # does not hurt and simplifies PLIST handling
 	${INSTALL_DATA} ${WRKSRC}/src/celestia/gtk/data/celestia.png \
 		${PREFIX}/share/pixmaps
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307041558.r64FwVQa087988>