From owner-cvs-all Sun Sep 15 13:13: 7 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D955637B400; Sun, 15 Sep 2002 13:13:06 -0700 (PDT) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50D0F43E3B; Sun, 15 Sep 2002 13:13:06 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.5/8.12.4) with ESMTP id g8FKD3PQ057841; Sun, 15 Sep 2002 13:13:03 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.5/8.12.4/Submit) id g8FKD3Ed057840; Sun, 15 Sep 2002 13:13:03 -0700 (PDT) (envelope-from dillon) Date: Sun, 15 Sep 2002 13:13:03 -0700 (PDT) From: Matthew Dillon Message-Id: <200209152013.g8FKD3Ed057840@apollo.backplane.com> To: Poul-Henning Kamp Cc: Bruce Evans , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_bio.c src/sys/sys bio.h References: <2157.1032119476@critter.freebsd.dk> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :I don't see any swear words in the above, only a not entirely :polished request that you examine facts before going totally Terry. : :-- :Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 I'm not sure why you want to believe that, or use it as a justification for blowing off the rather serious issues I've brought up instead of tackling or answering or even discussing it. I have looked at the code quite closely, and there are most certainly problems with it. In an interrupt/SMP environment the race you have created can be lost quite easily when Giant is no longer there to govern access and potentially result in seriously non-deterministic (terrible) performance for certain situations. Simply changing the timeout from one second to 1/10 second in your biowait() function is not going to solve any of the problems, it's just going to hide them a little more then before. Just put in a spin mutex and be done with it. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message