From owner-svn-ports-head@FreeBSD.ORG Tue Dec 3 19:29:05 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D032DE71; Tue, 3 Dec 2013 19:29:05 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BC8801C94; Tue, 3 Dec 2013 19:29:05 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id rB3JT5Jo056840; Tue, 3 Dec 2013 19:29:05 GMT (envelope-from sbruno@svn.freebsd.org) Received: (from sbruno@localhost) by svn.freebsd.org (8.14.7/8.14.7/Submit) id rB3JT5oN056839; Tue, 3 Dec 2013 19:29:05 GMT (envelope-from sbruno@svn.freebsd.org) Message-Id: <201312031929.rB3JT5oN056839@svn.freebsd.org> From: Sean Bruno Date: Tue, 3 Dec 2013 19:29:05 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r335589 - head/audio/clementine-player X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Dec 2013 19:29:05 -0000 Author: sbruno (src committer) Date: Tue Dec 3 19:29:05 2013 New Revision: 335589 URL: http://svnweb.freebsd.org/changeset/ports/335589 Log: Pointyhat to me. SPOTIFY support references the built in clementine library support module for the service that requires qca2 support. SPOTIFY_BLOB references some magical external library (from the vendor), that can be used in its place. There isn't a clearly obvious way to disable SPOTIFY support alltogether and the original, pre svn r335260 version of the SPOTIFY logic is correct Reported by: Jimmy Olgeni Modified: head/audio/clementine-player/Makefile Modified: head/audio/clementine-player/Makefile ============================================================================== --- head/audio/clementine-player/Makefile Tue Dec 3 19:12:34 2013 (r335588) +++ head/audio/clementine-player/Makefile Tue Dec 3 19:29:05 2013 (r335589) @@ -3,7 +3,7 @@ PORTNAME= clementine PORTVERSION= 1.2.0 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= audio MASTER_SITES= GOOGLE_CODE PKGNAMESUFFIX= -player @@ -60,7 +60,7 @@ WIIMOTEDEV_DESC= Wiimote support MOODBAR_DESC= Moodbar Support USE_BUILTIN_TAGLIB= Use Clementine builtin taglib support -OPTIONS_DEFAULT= AUDIOCD DEVICEKIT GIO LASTFM MTP VISUALISATION \ +OPTIONS_DEFAULT= AUDIOCD DEVICEKIT GIO LASTFM MTP SPOTIFY VISUALISATION \ WIIMOTEDEV MOODBAR .include @@ -132,10 +132,10 @@ CMAKE_ARGS+= -DENABLE_LIBMTP=OFF .endif .if ${PORT_OPTIONS:MSPOTIFY} -CMAKE_ARGS+= -DENABLE_SPOTIFY_BLOB=ON +CMAKE_ARGS+= -DENABLE_SPOTIFY=ON LIB_DEPENDS+= qca:${PORTSDIR}/devel/qca .else -CMAKE_ARGS+= -DENABLE_SPOTIFY_BLOB=OFF +CMAKE_ARGS+= -DENABLE_SPOTIFY=OFF -DENABLE_SPOTIFY_BLOB=OFF .endif .if ${PORT_OPTIONS:MVISUALISATION}