From owner-freebsd-current@FreeBSD.ORG Sat Jun 7 03:01:49 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 503BA37B401 for ; Sat, 7 Jun 2003 03:01:49 -0700 (PDT) Received: from out005.verizon.net (out005pub.verizon.net [206.46.170.143]) by mx1.FreeBSD.org (Postfix) with ESMTP id 66C9243FBF for ; Sat, 7 Jun 2003 03:01:38 -0700 (PDT) (envelope-from mtm@identd.net) Received: from kokeb.ambesa.net ([138.88.93.237]) by out005.verizon.net (InterMail vM.5.01.05.33 201-253-122-126-133-20030313) with ESMTP id <20030607100137.QOSI20032.out005.verizon.net@kokeb.ambesa.net>; Sat, 7 Jun 2003 05:01:37 -0500 Date: Sat, 7 Jun 2003 06:01:36 -0400 From: Mike Makonnen To: John Nielsen In-Reply-To: <200306070318.18920.john@jnielsen.net> References: <200306070318.18920.john@jnielsen.net> X-Mailer: Sylpheed version 0.8.10 (GTK+ 1.2.10; i386-portbld-freebsd5.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Authentication-Info: Submitted using SMTP AUTH at out005.verizon.net from [138.88.93.237] at Sat, 7 Jun 2003 05:01:37 -0500 Message-Id: <20030607100137.QOSI20032.out005.verizon.net@kokeb.ambesa.net> cc: current@freebsd.org Subject: Re: dhclient script in rc.d doesn't use ${dhcp_program} (conf/53007) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jun 2003 10:01:49 -0000 On Sat, 7 Jun 2003 03:18:18 -0600 John Nielsen wrote: > I just submitted a PR for a bug I noticed in the dhclient script. Namely, > it ignores the setting of dhcp_program from rc.conf. A one-line fix did > the trick for me, although there may be ramifications I'm not aware of. > hmm it looks like the bug is actually our name for the program. In the new rc system there is glue code that automagically overides the command. But in order for it to work the variable has to be named a certain way in rc.conf. In this case the variable name is dhcp_program, but what it should really be is dhclient_program. This is another variable we're going to have to deprecate. Thanks for reporting this! Cheers. -- Mike Makonnen | GPG-KEY: http://www.identd.net/~mtm/mtm.asc mtm@identd.net | D228 1A6F C64E 120A A1C9 A3AA DAE1 E2AF DBCC 68B9 mtm@FreeBSD.Org| FreeBSD - The Power To Serve