Date: Wed, 6 Feb 2013 10:14:35 -0500 From: John Baldwin <jhb@freebsd.org> To: Alfred Perlstein <bright@mu.org> Cc: svn-src-projects@freebsd.org, Alfred Perlstein <alfred@freebsd.org>, Eitan Adler <eadler@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r246380 - projects/cider/usr.bin/make Message-ID: <201302061014.35619.jhb@freebsd.org> In-Reply-To: <51125D8C.3050405@mu.org> References: <201302060436.r164awc3073100@svn.freebsd.org> <CAF6rxg=vW2cFTkdmz3Tcf28LJ-eYU7u1MaDhu7eQYN2A3TSEuA@mail.gmail.com> <51125D8C.3050405@mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, February 06, 2013 8:41:32 am Alfred Perlstein wrote: > On 2/5/13 8:40 PM, Eitan Adler wrote: > > On 5 February 2013 23:36, Alfred Perlstein <alfred@freebsd.org> wrote: > >> Author: alfred > >> Date: Wed Feb 6 04:36:57 2013 > >> New Revision: 246380 > >> URL: http://svnweb.freebsd.org/changeset/base/246380 > >> > >> Log: > >> Add headers needed to compile on OS X 10.7.5. > > Please make sure to annotate that these headers are required on > > !FreeBSD otherwise they may be removed if someone does a "include what > > you use" run. > > > > > Is there an existing way of doing this? > > I'm not sure if I should just do > #ifndef __FreeBSD__ > or something else? In this particular case I would be inclined to instead do something like: Makefile: .if defined(BOOTSTRAPPING_OSX) CFLAGS+= -include osx_bootstrap.h .endif osx_bootstrap.h: #include <sys/types.h> #include <stdint.h> Doesn't hurt to just include those while building all of make I think and that is a less invasive change. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302061014.35619.jhb>