From owner-svn-src-user@FreeBSD.ORG Fri Apr 11 22:07:33 2014 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 749199EA; Fri, 11 Apr 2014 22:07:33 +0000 (UTC) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2AB60144B; Fri, 11 Apr 2014 22:07:33 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 13C6E25D389C; Fri, 11 Apr 2014 22:07:29 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 3CA5EC22BF1; Fri, 11 Apr 2014 22:07:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id cY9UziEtED03; Fri, 11 Apr 2014 22:07:27 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:c0be:2d9:cabc:ad86] (unknown [IPv6:fde9:577b:c1a9:4410:c0be:2d9:cabc:ad86]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id D54CBC22BF0; Fri, 11 Apr 2014 22:07:26 +0000 (UTC) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: svn commit: r264358 - user/ae/inet6/sys/netinet6 From: "Bjoern A. Zeeb" In-Reply-To: <201404112148.s3BLmgC8064206@svn.freebsd.org> Date: Fri, 11 Apr 2014 22:07:19 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201404112148.s3BLmgC8064206@svn.freebsd.org> To: "Andrey V. Elsukov" X-Mailer: Apple Mail (2.1874) Cc: src-committers@freebsd.org, svn-src-user@freebsd.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Apr 2014 22:07:33 -0000 On 11 Apr 2014, at 21:48 , Andrey V. Elsukov wrote: > Author: ae > Date: Fri Apr 11 21:48:41 2014 > New Revision: 264358 > URL: http://svnweb.freebsd.org/changeset/base/264358 >=20 > Log: > Application can use a global address belonging to the interface other > than the outgoing. >=20 > Found and tested by: bind9 Yeah right and then BCP38 catches is on the router and drops the packet. This change just sounds wrong. Maybe the application should be improved = instead. > Modified: > user/ae/inet6/sys/netinet6/in6_src.c >=20 > Modified: user/ae/inet6/sys/netinet6/in6_src.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- user/ae/inet6/sys/netinet6/in6_src.c Fri Apr 11 21:14:10 2014 = (r264357) > +++ user/ae/inet6/sys/netinet6/in6_src.c Fri Apr 11 21:48:41 2014 = (r264358) > @@ -411,9 +411,9 @@ check_addrs(const struct sockaddr_in6 *s > struct in6_ifaddr *ia; >=20 > /* > - * Check that source address is available on the interface. > + * Check that source address is available. > */ > - ia =3D in6ifa_ifpwithaddr(ifp, &src->sin6_addr); > + ia =3D in6ifa_ifwithaddr(&src->sin6_addr, src->sin6_scope_id); > if (ia =3D=3D NULL || ( > ia->ia6_flags & (IN6_IFF_ANYCAST | IN6_IFF_NOTREADY))) { > if (ia !=3D NULL) >=20 =97=20 Bjoern A. Zeeb ????????? ??? ??????? ??????: '??? ??? ???? ?????? ??????? ?? ?? ??????? ??????? ??? ????? ????? ???? ?????? ?? ????? ????', ????????? ?????????, "??? ????? ?? ?????", ?.???