Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 May 2015 13:19:52 -0700
From:      Cy schubert <cschuber@gmail.com>
To:        Baptiste Daroussin <bapt@FreeBSD.org>, Cy Schubert <cy@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   RE: svn commit: r280849 - in head: contrib/ntp contrib/ntp/adjtimedcontrib/ntp/arlib contrib/ntp/clockstuff contrib/ntp/conf contrib/ntp/htmlcontrib/ntp/html/build contrib/ntp/html/drivers contrib/nt...
Message-ID:  <556383e7.a5a9440a.7137.ffffe47c@mx.google.com>

next in thread | raw e-mail | index | archive | help
Thanks bapt@. I will take a look after work tonight.

~Cy

-----Original Message-----
From: Baptiste Daroussin
Sent: 25/05/2015 12:45
To: Cy Schubert
Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-head@freeb=
sd.org
Subject: Re: svn commit: r280849 - in head: contrib/ntp contrib/ntp/adjtime=
dcontrib/ntp/arlib contrib/ntp/clockstuff contrib/ntp/conf contrib/ntp/html=
contrib/ntp/html/build contrib/ntp/html/drivers contrib/nt...

On Mon, Mar 30, 2015 at 01:30:17PM +0000, Cy Schubert wrote:
> Author: cy
> Date: Mon Mar 30 13:30:15 2015
> New Revision: 280849
> URL: https://svnweb.freebsd.org/changeset/base/280849
>=20
> Log:
>   MFV ntp 4.2.8p1 (r258945, r275970, r276091, r276092, r276093, r278284)
>  =20
>   Thanks to roberto for providing pointers to wedge this into HEAD.
>  =20
>   Approved by:	roberto
>=20
Thanks for the update, but you have reintroduced overlinking of useless
libraries all over ntp.

for example with ntpdc:
The binary does not need at all to link with ncurses explicitly
The binary does not need to link with both libedit and readline (libedit is
enough and prefered)
The binary does not need to link to libmd as it does not use it.
The binary needs libcrypto but absolutly not to libssl

Also ntpdc does not build if WITHOUT_OPENSSL because in the config.h it is
hardcoded that it needs openssl, for example:
#define USE_OPENSSL_CRYPTO_RAND 1

Before the update, libmd was used for the digests functions. gGven now it i=
s
hardcoded that openssl is required libmd should be replaced by libcrypto bu=
t
you should not have both.

I'm working on fixing the overlink, but given I know nothing about libntp's=
 code
I will let others have a look on what to do with the MK_OPENSSL.

Best regards,
Bapt



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?556383e7.a5a9440a.7137.ffffe47c>