From owner-svn-src-head@FreeBSD.ORG Mon May 25 20:19:53 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2F84AFB4; Mon, 25 May 2015 20:19:53 +0000 (UTC) (envelope-from cschuber@gmail.com) Received: from mail-pd0-x22b.google.com (mail-pd0-x22b.google.com [IPv6:2607:f8b0:400e:c02::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F0F57CB6; Mon, 25 May 2015 20:19:52 +0000 (UTC) (envelope-from cschuber@gmail.com) Received: by pdbki1 with SMTP id ki1so33428453pdb.1; Mon, 25 May 2015 13:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:mime-version:from:subject:date:to:cc:content-type; bh=YSpQMmptJ9Gd90u+oC5H7xcge8MxDKO4XqgMmvq4uiE=; b=CEQ3jzO2DRgQkCIs3Hhyr/jKMkPwErFISsXiJmp1cFUQiBVTiGoNhy4bESO0tUIxdN Z63WLqoXvB3mMwaSi9UKO7LVxrMdqOQDPnOS1vUGpx6vPPIXPJL+Q9A796CODw4BWhKo deyRSDv3gsNPawCwjeEq5WjlsccDGVsVdi2U5uLoaPIuSuvZtTK3FjTy8+ArnWKrJoHm gFeq8WiQQqG+8Iz0E3apH8gQwYULYdUizNpkMjV+yfeZ8lat7fIyckdx8tzpWue1RfvC 9hqKazziitsrV6/QKU3AaH0XPhJ/4ofY+kndQeAAvnt8iIwXY59S9JpeF+CiZ/kQNg0k jJ1w== X-Received: by 10.66.140.36 with SMTP id rd4mr42306254pab.109.1432585192436; Mon, 25 May 2015 13:19:52 -0700 (PDT) Received: from [10.168.3.106] (S0106d4ca6d8943b0.gv.shawcable.net. [24.68.134.59]) by mx.google.com with ESMTPSA id af5sm10814793pbc.90.2015.05.25.13.19.51 (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 25 May 2015 13:19:51 -0700 (PDT) Message-ID: <556383e7.a5a9440a.7137.ffffe47c@mx.google.com> MIME-Version: 1.0 From: Cy schubert Subject: RE: svn commit: r280849 - in head: contrib/ntp contrib/ntp/adjtimedcontrib/ntp/arlib contrib/ntp/clockstuff contrib/ntp/conf contrib/ntp/htmlcontrib/ntp/html/build contrib/ntp/html/drivers contrib/nt... Date: Mon, 25 May 2015 13:19:52 -0700 To: Baptiste Daroussin , Cy Schubert CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2015 20:19:53 -0000 Thanks bapt@. I will take a look after work tonight. ~Cy -----Original Message----- From: Baptiste Daroussin Sent: 25/05/2015 12:45 To: Cy Schubert Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-head@freeb= sd.org Subject: Re: svn commit: r280849 - in head: contrib/ntp contrib/ntp/adjtime= dcontrib/ntp/arlib contrib/ntp/clockstuff contrib/ntp/conf contrib/ntp/html= contrib/ntp/html/build contrib/ntp/html/drivers contrib/nt... On Mon, Mar 30, 2015 at 01:30:17PM +0000, Cy Schubert wrote: > Author: cy > Date: Mon Mar 30 13:30:15 2015 > New Revision: 280849 > URL: https://svnweb.freebsd.org/changeset/base/280849 >=20 > Log: > MFV ntp 4.2.8p1 (r258945, r275970, r276091, r276092, r276093, r278284) > =20 > Thanks to roberto for providing pointers to wedge this into HEAD. > =20 > Approved by: roberto >=20 Thanks for the update, but you have reintroduced overlinking of useless libraries all over ntp. for example with ntpdc: The binary does not need at all to link with ncurses explicitly The binary does not need to link with both libedit and readline (libedit is enough and prefered) The binary does not need to link to libmd as it does not use it. The binary needs libcrypto but absolutly not to libssl Also ntpdc does not build if WITHOUT_OPENSSL because in the config.h it is hardcoded that it needs openssl, for example: #define USE_OPENSSL_CRYPTO_RAND 1 Before the update, libmd was used for the digests functions. gGven now it i= s hardcoded that openssl is required libmd should be replaced by libcrypto bu= t you should not have both. I'm working on fixing the overlink, but given I know nothing about libntp's= code I will let others have a look on what to do with the MK_OPENSSL. Best regards, Bapt