From owner-freebsd-bugs@FreeBSD.ORG Sat Jul 19 23:46:36 2014 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 598A1A0C for ; Sat, 19 Jul 2014 23:46:36 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 40F4A2A36 for ; Sat, 19 Jul 2014 23:46:36 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s6JNkanS095792 for ; Sat, 19 Jul 2014 23:46:36 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 191974] New: |ln -sF| never calls rmdir(2) on target_file == target_dir, only target_dir/basename Date: Sat, 19 Jul 2014 23:46:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@vfemail.net X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter blocked Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2014 23:46:36 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191974 Bug ID: 191974 Summary: |ln -sF| never calls rmdir(2) on target_file == target_dir, only target_dir/basename Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: jbeich@vfemail.net Blocks: 92149 According to the manpage -F option is supposed to make ln(1) remove target_file which happens to be a directory. What actually happens is target_file converted to target_dir/basename and always fails when tested with S_ISDIR(). It's also unclear why -s flag is required. If the source_file is not a directory ln(1) can just call rmdir(2) + link(2) instead of rmdir(2) + symlink(2). $ echo >foo $ mkdir bar $ ln -sF foo bar $ ls bar foo but replacing children works fine $ echo >foo $ mkdir -p bar/foo $ ln -sF foo bar $ stat -x bar/foo | head -2 File: "bar/foo" Size: 3 FileType: Symbolic Link -- You are receiving this mail because: You are the assignee for the bug.