Date: Tue, 26 Aug 2008 17:35:08 -0700 From: Greg Lewis <glewis@eyesbeyond.com> To: "Rick C. Petty" <rick-freebsd2008@kiwi-computer.com> Cc: freebsd-eclipse@freebsd.org Subject: Re: wrong JAVA_VENDOR Message-ID: <20080827003508.GA39878@misty.eyesbeyond.com> In-Reply-To: <20080826191341.GA37568@keira.kiwi-computer.com> References: <20080826191341.GA37568@keira.kiwi-computer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 26, 2008 at 02:13:41PM -0500, Rick C. Petty wrote:
> If you install java/diablo-jdk16 instead of java/jdk16, the JAVA_VENDOR is
> "freebsd". The java/eclipse Makefile sets JAVA_VENDOR to "bsdjava". Why
> is this? This makes it so that you cannot run eclipse with only
> diablo-jdk16 installed. Why is it even being set? Isn't it enough that we
> use JAVA_OS=native ??? I suggest the following patch:
This is because people would install diablo-jdk15 on FreeBSD 7.x. This
will run Java programmes if you have compat6x installed and some libmap
entries set up, but it won't run Eclipse. Now that we have diablo-jdk16
which has a native 7.x version we could change 700000 to 800000, but the
risk is that people on 7.x with diablo-jdk15 already installed will then
be able to install with it guaranteed to break.
I'll try an alternative change.
> --- ports/java/eclipse/Makefile.orig 2008-08-14 19:17:21.000000000 -0500
> +++ ports/java/eclipse/Makefile 2008-08-26 19:13:03.000000000 -0500
> @@ -60,10 +60,6 @@
>
> .include <bsd.port.pre.mk>
>
> -.if ${OSVERSION} >= 700000
> -JAVA_VENDOR= bsdjava
> -.endif
> -
> .if !defined(WITHOUT_MOZILLA)
> MAKE_MOZILLA= make_mozilla
> BROWSER= ${GECKO}
>
>
> -- Rick C. Petty
> _______________________________________________
> freebsd-eclipse@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-eclipse
> To unsubscribe, send any mail to "freebsd-eclipse-unsubscribe@freebsd.org"
--
Greg Lewis Email : glewis@eyesbeyond.com
Eyes Beyond Web : http://www.eyesbeyond.com
Information Technology FreeBSD : glewis@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080827003508.GA39878>