From owner-freebsd-sparc64@FreeBSD.ORG Fri Jun 18 03:23:27 2004 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A705316A4CE for ; Fri, 18 Jun 2004 03:23:27 +0000 (GMT) Received: from ns.kt-is.co.kr (ns.kt-is.co.kr [211.218.149.125]) by mx1.FreeBSD.org (Postfix) with ESMTP id E196343D48 for ; Fri, 18 Jun 2004 03:23:26 +0000 (GMT) (envelope-from yongari@kt-is.co.kr) Received: from michelle.kt-is.co.kr (ns2.kt-is.co.kr [220.76.118.193]) (authenticated bits=128) by ns.kt-is.co.kr (8.12.10/8.12.10) with ESMTP id i5I3KTAh069745 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 18 Jun 2004 12:20:29 +0900 (KST) Received: from michelle.kt-is.co.kr (localhost.kt-is.co.kr [127.0.0.1]) by michelle.kt-is.co.kr (8.12.10/8.12.10) with ESMTP id i5I3M01r015572 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 18 Jun 2004 12:22:00 +0900 (KST) (envelope-from yongari@kt-is.co.kr) Received: (from yongari@localhost) by michelle.kt-is.co.kr (8.12.10/8.12.10/Submit) id i5I3LxhK015571; Fri, 18 Jun 2004 12:21:59 +0900 (KST) (envelope-from yongari@kt-is.co.kr) Date: Fri, 18 Jun 2004 12:21:59 +0900 From: Pyun YongHyeon To: Thomas Moestl Message-ID: <20040618032159.GA15377@kt-is.co.kr> References: <20040616034520.GB7887@kt-is.co.kr> <20040617024759.GA5610@timesink.dyndns.org> <20040617063022.GA11797@kt-is.co.kr> <20040618012045.GF747@timesink.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040618012045.GF747@timesink.dyndns.org> User-Agent: Mutt/1.4.1i X-Filter-Version: 1.11a (ns.kt-is.co.kr) cc: freebsd-sparc64@freebsd.org Subject: Re: TCP/UDP cksum offload on hme(4) X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: yongari@kt-is.co.kr List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2004 03:23:27 -0000 On Fri, Jun 18, 2004 at 03:20:45AM +0200, Thomas Moestl wrote: ... > > Just one further remark: > > > + if ((ifp->if_flags & IFF_LINK0) != 0) > > + hme_csum_features |= CSUM_UDP; > > + else > > + hme_csum_features &= ~CSUM_UDP; > > Maybe if_hwassist should be changed accordingly in this case, too. It Yes, it needs if_hwassist modification too. > might be a bit counter-intuitive to need to do an extra SIOCSIFCAP > before this takes effect. > > > Thanks for your changes! Since people have reported that this patch > works well on PCI hmes, I am planning to commit it soon. > Great! Thank you very much. Regards, Pyun YongHyeon -- Pyun YongHyeon