Date: Tue, 12 Oct 2004 14:51:57 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_subr.c Message-ID: <20041012215157.GP38364@elvis.mu.org> In-Reply-To: <200410121827.i9CIREMa030971@repoman.freebsd.org> References: <200410121827.i9CIREMa030971@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I like this, my only concern is that there may be places that call this with locks held but with the kernel/user buffer wired so that it can't fault. Are you sure this isn't the case? (specifically for some sysctls) * John Baldwin <jhb@FreeBSD.org> [041012 11:27] wrote: > jhb 2004-10-12 18:27:14 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_subr.c > Log: > Add a WITNESS_WARN() to uiomove() to whine if locks are held when this > function is called. > > MFC after: 1 month > > Revision Changes Path > 1.89 +2 -0 src/sys/kern/kern_subr.c -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041012215157.GP38364>