From owner-cvs-all@FreeBSD.ORG  Tue Oct 12 21:51:57 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8A7D616A4CE; Tue, 12 Oct 2004 21:51:57 +0000 (GMT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6DCFD43D46; Tue, 12 Oct 2004 21:51:57 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 626425C95F; Tue, 12 Oct 2004 14:51:57 -0700 (PDT)
Date: Tue, 12 Oct 2004 14:51:57 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20041012215157.GP38364@elvis.mu.org>
References: <200410121827.i9CIREMa030971@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200410121827.i9CIREMa030971@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_subr.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Oct 2004 21:51:57 -0000

I like this, my only concern is that there may be places that
call this with locks held but with the kernel/user buffer wired
so that it can't fault.

Are you sure this isn't the case?  (specifically for some sysctls)

* John Baldwin <jhb@FreeBSD.org> [041012 11:27] wrote:
> jhb         2004-10-12 18:27:14 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             kern_subr.c 
>   Log:
>   Add a WITNESS_WARN() to uiomove() to whine if locks are held when this
>   function is called.
>   
>   MFC after:      1 month
>   
>   Revision  Changes    Path
>   1.89      +2 -0      src/sys/kern/kern_subr.c

-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684