Date: Tue, 30 Apr 2019 21:15:19 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Gleb Popov <arrowd@freebsd.org> Cc: svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r500497 - head/security/klee Message-ID: <20190430191519.GA91200@ThinkPad-X200.g.anongoth.pl> In-Reply-To: <CALH631nAfffNa0O8cCoWMq_HiwPBY=WUmF-8EL8eWx9B5KioTg@mail.gmail.com> References: <201904301429.x3UETKUD077864@repo.freebsd.org> <CALH631nAfffNa0O8cCoWMq_HiwPBY=WUmF-8EL8eWx9B5KioTg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--vpCXpI0ZG2tL7C0F Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Is there a point in creating a PR that you accept and then adding you to re= viewers? Or do you mean only doing a review? On 19-04-30 18:39:02, Gleb Popov wrote: >On Tue, Apr 30, 2019 at 6:29 PM Piotr Kubaj <pkubaj@freebsd.org> wrote: > >> Author: pkubaj >> Date: Tue Apr 30 14:29:20 2019 >> New Revision: 500497 >> URL: https://svnweb.freebsd.org/changeset/ports/500497 >> >> Log: >> security/klee: fix build with GCC-based architectures >> >> Add USES=3Dcompiler:c++14-lang to fix build on GCC architectures: >> Make Error in lib/Basic/CMakeLists.txt: >> Target "kleeBasic" requires the language dialect "CXX14" (with compi= ler >> extensions), but CMake does not know the compile flags to use to >> enable it. >> >> PR: 237623 >> Approved by: arrowd (maintainer), mat (mentor) >> Differential Revision: https://reviews.freebsd.org/D20088 >> >> Modified: >> head/security/klee/Makefile >> >> Modified: head/security/klee/Makefile >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/security/klee/Makefile Tue Apr 30 14:26:31 2019 (r500496) >> +++ head/security/klee/Makefile Tue Apr 30 14:29:20 2019 (r500497) >> @@ -17,7 +17,8 @@ BUILD_DEPENDS=3D >> llvm-config${LLVM_DEFAULT}:devel/llvm${ >> RUN_DEPENDS=3D llvm-config${LLVM_DEFAULT}:devel/llvm${LLVM_DEFAULT} \ >> ${PYTHON_PKGNAMEPREFIX}tabulate>0:devel/py-tabulate@ >> ${PY_FLAVOR} >> >> -USES=3D cmake localbase pkgconfig python:3.5+,run shebangfix >> +USES=3D cmake compiler:c++14-lang localbase pkgconfig >> python:3.5+,run \ >> + shebangfix >> USE_GITHUB=3D yes >> SHEBANG_FILES=3D tools/klee-stats/klee-stats tools/ktest-tool/ktest-tool >> USE_LDCONFIG=3D yes >> >> >I have an account on our Phab, so you can add @arrowd to reviewers there. > >--=20 >This message has been scanned for viruses and >dangerous content by MailScanner, and is >believed to be clean. > --vpCXpI0ZG2tL7C0F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEycyIeNkkgohzsoorelmbhSCDnJ0FAlzInsdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM5 Q0M4ODc4RDkyNDgyODg3M0IyOEEyQjdBNTk5Qjg1MjA4MzlDOUQACgkQelmbhSCD nJ2yQxAAlXkYDCs2RKpmeAv5Tt0S7gIs2tY654zcEV5IgoizPaJ5Z55do7DT3xxa uYRlunBEnPBCzs4FeVZTU14nNtsSy2ldr8OvhE46tV9vVtz8lBOIJw8oL6nz0QGX zR4G2TL+kODtsIiUIaaCK4ZR5TZS7iQJG3xck5GaWbLx+18NOOWZbiuZaZZl4Jck unlATclxxwvohRBJoLvKC5bT5glUyHDOL0gt4ABgXPusKLYR96x+IQHlUU3oRoE0 EbjZGCkVxR43wGtJmytWVErUttEX9xPAr50iGeeXD/szlmTRF6ntyqt9BrnOOY6a SOsY1FZKsnLPu4fIG4gxwemDRLONAhZ7x0psjgTK3FB8STNs719M1exQQ8aL6k2c Gh8HcPkPnUetcAGPWqOh+hJOQPAopVXpjeBRhbMU4vrY1Jv1tOzAJa56u+J6dqKr V4kHRBVVxBXG0EosyV+OC5Zs2eaDaJY+ZYJHLz8NjZm0z3wiB7vzzbQ+wtiAaxA+ MLvFpDWjoF8oOHZgU68W9R5FyzRsV5gPKCQcaaN4k6HYWFNEIsxbVirGHXMpEPLe jnApAy2bc0BRZijOmQVo3CQnzWciFvpnVeMgRtJeK0LJ23Nr90e+sQ5NMHADnMxU S2km/5KODiIb1+60YTh9T4+h9YtN2eOoE8xZJze2qu5Zf/Y1Feg= =LhV+ -----END PGP SIGNATURE----- --vpCXpI0ZG2tL7C0F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190430191519.GA91200>