From owner-freebsd-arm@freebsd.org Fri Jan 29 04:20:06 2016 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D77E1A728B6 for ; Fri, 29 Jan 2016 04:20:06 +0000 (UTC) (envelope-from amutu@amutu.com) Received: from mail-yk0-x22e.google.com (mail-yk0-x22e.google.com [IPv6:2607:f8b0:4002:c07::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 936A015B7 for ; Fri, 29 Jan 2016 04:20:06 +0000 (UTC) (envelope-from amutu@amutu.com) Received: by mail-yk0-x22e.google.com with SMTP id k129so56782705yke.0 for ; Thu, 28 Jan 2016 20:20:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amutu-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=IOQPgvIevE77/UBBpBRk/cNAfLYag8FQZgdVSr8/K2Q=; b=0rZD7v2liO8cvHteIBTl1Ee+Wsq7FNm3hui57NNx08UNZXtiGWBeK6eoIyrh5Uziry vXjfXBE/lpZrQNx5MpaKwVrJwNNwnXGKNU8WFTg56nZPtt/ECFE5apWCYvRGOsShdqcq +9p6aCFjuv7m1Vy/MQUuaCi7/Me/69OMAY4hee6bZUzMpls04v9GQ+49U0qEKYASO0/8 OYI2RZMc4pOEGgnROGA2cmZYU+0TnBmzMbhEIl9am5ItNkII3zu1AUmNXL0Iid+pwawF on3MaXWJTaodVXjuCN6q1DDGLj6WoXa/yVM3+jCOcDN05398Io/lQp3RQK2jRxGM+Qcm 7p7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=IOQPgvIevE77/UBBpBRk/cNAfLYag8FQZgdVSr8/K2Q=; b=WKoX4mjxg9rCVcBzbVPWYLFbWK1QMZwcNOQ5GHCg9PehCkPM031cEGa7Mtte+3i9jD unqHgJVyDOJlejbgH+WbcSOybkdOVeJpGTY3m8BUAZ35t7v9vFpHtWF8AluM04MH8fb7 1QFuwRaDhRKBmH+PBr/tc/M/UY6HxhD88d72vyv4dkN/sAbs1mpVrRDSXUuIvWMFDDDz izku/htqF3BZHEWjQSh+g4J9mbNjmW38c9oQw98vwmFYIMOmTA//49Y+sp78shGWoUvp 058LIwR0fA3b40Y8JxaFu31ECMqG1jkB8HOsD6ci4Z5Jb71YDZdIIz56i/j1PiXiuEeP hRyQ== X-Gm-Message-State: AG10YOTRNFx847lWhpG4dJJ5wjMYTJLlr02cUNcGkboTZpgwJ+mMO1QmJ8lcns/j/odgnQ== X-Received: by 10.129.4.131 with SMTP id 125mr3370048ywe.253.1454041205090; Thu, 28 Jan 2016 20:20:05 -0800 (PST) Received: from mail-yk0-f169.google.com (mail-yk0-f169.google.com. [209.85.160.169]) by smtp.gmail.com with ESMTPSA id p63sm10986901ywf.8.2016.01.28.20.20.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jan 2016 20:20:04 -0800 (PST) Received: by mail-yk0-f169.google.com with SMTP id r207so12876382ykd.2; Thu, 28 Jan 2016 20:20:03 -0800 (PST) X-Received: by 10.129.91.132 with SMTP id p126mr3510772ywb.188.1454041203768; Thu, 28 Jan 2016 20:20:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.79.6 with HTTP; Thu, 28 Jan 2016 20:19:44 -0800 (PST) In-Reply-To: References: <1453862939.42081.25.camel@freebsd.org> <1453867724.42081.28.camel@freebsd.org> <1453903433.42081.30.camel@freebsd.org> From: Jov Date: Fri, 29 Jan 2016 12:19:44 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Bug 206658] Bus error for pfctl -sa on rpi2 r294499 snap To: Guy Yur , freebsd-pf@freebsd.org Cc: Ian Lepore , freebsd-arm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2016 04:20:06 -0000 This patch works=EF=BC=8Cthanks very much ! will these patches to be commited to the offical svn? I add freebsd-pf ML. Jov blog: http:amutu.com/blog 2016-01-29 5:26 GMT+08:00 Guy Yur : > Hi, > > On Thu, Jan 28, 2016 at 2:06 PM, Jov wrote: > > bus error at the similar position: > > > > Program received signal SIGBUS, Bus error. > > 0x00021614 in print_host (addr=3D0x2065111a, port=3D15268, af=3D2 '\002= ', > > opts=3D1024) at /usr/src/sbin/pfctl/pf_print_state.c:178 > > warning: Source file is more recent than executable. > > > > 178 memcpy(&aw.v.a.addr, addr, sizeof(aw.v.a.addr)); > > Current language: auto; currently minimal > > (gdb) p addr > > $1 =3D (struct pf_addr *) 0x2065111a > > ... > > > > Jov > > The compiler optimizes the memcpy to a series of ldr and str > instructions and since addr is unaligned you still get SIGBUS. > > I encountered the same problem on a BeagleBone Black. > https://lists.freebsd.org/pipermail/freebsd-arm/2014-January/007237.html > > non-intrustive patch with changes only in print_state() > pfsync_state is __packed so the keys can be copied safely to > stack variables which will be aligned (and addr inside it). > > https://github.com/guyyur/freebsd-src_patches/blob/master/pfctl_arm_segbu= s__ver1_part1.patch > > Bug report with patch to separate pfsync and pfioc state > structures but breaks backward compatibility: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D185617 > > -- Guy >