Date: Wed, 14 Aug 2019 11:04:03 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: Ian Lepore <ian@freebsd.org>, current@FreeBSD.org, x11@FreeBSD.org Subject: Re: HEADSUP: drm-current-kmod now installs sources Message-ID: <d2233b2b-1139-34a3-e7f5-511963c4f72d@FreeBSD.org> In-Reply-To: <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <bee728a59abb033657a20de4e716698fb2b1c927.camel@freebsd.org> <b2951cc6-e5e8-6c14-6368-41d51f949011@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <c3a3eb30-584f-a5f1-18f7-b94a45d20dd7@FreeBSD.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/14/19 10:23 AM, Emmanuel Vadot wrote: > On Wed, 14 Aug 2019 10:13:48 -0700 > John Baldwin <jhb@FreeBSD.org> wrote: > >> On 8/14/19 9:22 AM, Ian Lepore wrote: >>> This all sounds vaguely wrong, backwards, to me. A developer who is >>> using a given module on their build system might want that module to be >>> rebuilt automatically, but only if the build parameters match those of >>> the running build host system. >>> >>> If my build host is running freebsd 12 amd64 and I'm doing a build for >>> freebsd 13 armv7, I have no interest in automatic rebuilds of an amd64 >>> driver module for a different OS arch and version just because that >>> module happens to be installed on the system I use to do crossbuilds. >>> >>> My objections are theoretical... this automation just seems improperly >>> designed to me. But it won't actually affect me in any way, because I >>> don't build video driver modules from ports, and I don't run freebsd >>> current on my build host machine. Probably the number of people doing >>> crossbuilding is small enough that nobody else is going to object to >>> this "the whole world is amd64" automation. >> >> You assume DRM is amd64-only when it is definitely not. It also has >> suitable guards in its Makefile to only build the relevant kernel >> modules on supported architectures. > > I clearly don't want to spend time to build the drm and radeon modules > when I'm hacking on arm64. Didn't you when DRM2 was in base? Do you use MODULES_OVERRIDE now to limit the number of modules you are building? Setting LOCAL_MODULES would be no different to setting MODULES_OVERRIDE. If you aren't setting MODULES_OVERRIDE, then I don't buy your argument as the default set of modules dwarfs DRM several times over. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d2233b2b-1139-34a3-e7f5-511963c4f72d>