Date: Mon, 2 Dec 2013 00:07:35 +0100 From: Jilles Tjoelker <jilles@stack.nl> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler <eadler@FreeBSD.org> Subject: Re: svn commit: r258779 - in head/sys/dev: cesa drm drm2/i915 drm2/radeon hatm Message-ID: <20131201230735.GB24849@stack.nl> In-Reply-To: <20131201075944.GF59496@kib.kiev.ua> References: <201311302216.rAUMGcPA037268@svn.freebsd.org> <20131201075944.GF59496@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 01, 2013 at 09:59:44AM +0200, Konstantin Belousov wrote: > On Sat, Nov 30, 2013 at 10:16:38PM +0000, Eitan Adler wrote: > > Author: eadler > > Date: Sat Nov 30 22:16:37 2013 > > New Revision: 258779 > > URL: http://svnweb.freebsd.org/changeset/base/258779 > > > > Log: > > Similar to the (1 << 31) case it is not defined to do (2 << 30). > > > > Modified: > ... > > head/sys/dev/drm2/i915/i915_reg.h > Revert the drm2/i915 changes from this and following commits now. > You did not contacted obvious maintainer of the file. > The changes are pointless and make the import of upstream changes > harder; for i915_reg.h, much harder. This is a valid concern. The change should be submitted to upstream; if upstream does not want the change, it is better to avoid the issue by adding -fno-strict-overflow for the offending files, matching upstream. > Not to mention that the whole churn is not needed if the > -fno-strict-overflow flag is used. I think the undefined shifts should be fixed where possible and not in contributed code. -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131201230735.GB24849>