Date: Thu, 7 Dec 2017 06:22:30 -0500 From: Joe Marcus Clarke <marcus@freebsd.org> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r447981 - in head/ports-mgmt/portlint: . src Message-ID: <df5a59b6-df44-9a2c-2a4d-d85b15376a97@freebsd.org> In-Reply-To: <20171207081308.5bxt5mp2o5wr33un@ptrcrt.ch> References: <201708151243.v7FChEAF043279@repo.freebsd.org> <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> <20171207081055.xtssqrp5okethfeu@ptrcrt.ch> <20171207081308.5bxt5mp2o5wr33un@ptrcrt.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --C7ju7B9pBgpTPoVJn7h7RGsm8xCSPJaUL Content-Type: multipart/mixed; boundary="msHMxnKmIxRLjbM9S1LGAfLKof52PGS6S"; protected-headers="v1" From: Joe Marcus Clarke <marcus@freebsd.org> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <df5a59b6-df44-9a2c-2a4d-d85b15376a97@freebsd.org> Subject: Re: svn commit: r447981 - in head/ports-mgmt/portlint: . src References: <201708151243.v7FChEAF043279@repo.freebsd.org> <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> <20171207081055.xtssqrp5okethfeu@ptrcrt.ch> <20171207081308.5bxt5mp2o5wr33un@ptrcrt.ch> In-Reply-To: <20171207081308.5bxt5mp2o5wr33un@ptrcrt.ch> --msHMxnKmIxRLjbM9S1LGAfLKof52PGS6S Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 12/7/17 03:13, Pietro Cerutti wrote: > On Dec 7 17 08:10, Pietro Cerutti wrote: >> On Dec 7 17 08:04, Pietro Cerutti wrote: >>> On Aug 15 17 12:43, Joe Marcus Clarke wrote: >>>> Author: marcus >>>> Date: Tue Aug 15 12:43:14 2017 >>>> New Revision: 447981 >>>> URL: https://svnweb.freebsd.org/changeset/ports/447981 >>>> >>>> Log: >>>> Update to 2.17.12. >>> >>>> @@ -3400,6 +3437,11 @@ sub abspathname { >>>> =20 >>>> if ($pre =3D~ /MASTER_SITE_SUBDIR/) { >>>> # MASTER_SITE_SUBDIR lines are ok. >>>> + $i =3D ''; >>>> + } >>>> + if ($s =3D~ /\$\{[^}]*?$i/) { >>>> + # If we're inside a make variable, we probably do not have >>>> + # an absolute path. >>>> $i =3D ''; >>>> } >>>> } >>>> >>> >>> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&= 1 )=20 >>> <-- HERE / at /usr/local/bin/portlint line 3443. >>> >>> I think the ? doesn't belong there. >> >> No, my analysis was wrong. It's about the contents of the $i variable.= =20 >> Here's why. You can reproduce by portlint -AC in net-im/openfire. >> >> i is /var/log/openfire >> WARN: Makefile: possible use of absolute pathname "/var/log/openfire".= >> >> i is /var/db/openfire >> WARN: Makefile: possible use of absolute pathname "/var/db/openfire". >> >> i is /dev/null 2>&1 ) >> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&1= )=20 >> <-- HERE / at /usr/local/bin/portlint line 3444. >=20 > Surrounding $i with \Q and \E in the regex solves the problem. >=20 >=20 Thanks. I'll commit a quick fix ahead of the next release. Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --msHMxnKmIxRLjbM9S1LGAfLKof52PGS6S-- --C7ju7B9pBgpTPoVJn7h7RGsm8xCSPJaUL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTMiWQHc8wChijkr7lvaI+K/hTPhwUCWikkeQAKCRBvaI+K/hTP h18AAJoCx0ZbOcfLAlkE+IH0+2OHI9fAXwCgkja36MkgVtNEQ5JPIoCYvm/wyOo= =Gqer -----END PGP SIGNATURE----- --C7ju7B9pBgpTPoVJn7h7RGsm8xCSPJaUL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?df5a59b6-df44-9a2c-2a4d-d85b15376a97>