From owner-freebsd-current@FreeBSD.ORG Tue Oct 16 00:49:46 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1C0DF812; Tue, 16 Oct 2012 00:49:46 +0000 (UTC) (envelope-from hiren.panchasara@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id B35A78FC17; Tue, 16 Oct 2012 00:49:45 +0000 (UTC) Received: by mail-ob0-f182.google.com with SMTP id wc20so7442280obb.13 for ; Mon, 15 Oct 2012 17:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=l7IwwTVbylxLp40wyzAsbS9revr+YjhACvGkz843Zjs=; b=eQcFtjwIH4y5nYo2awCJKfOJKPBNQ4mdDqbLM2AYQ+VXiR3A8fbKnEsUGdnjH9nTxS KHX1d9pZSQ92aA9yINF+TnG9V6Ca31V+UUoBX7PgiG9gyLpTpOKT7B2+o0/fAZPyUnxi o0sXJF3gWaEFW/5/616kBclXC7DmljV/iwFZJlTveBcM/iL9Xr2g74BHE8Hex8jxkA1Y 4luOiQJA6aiqxSqAp/3EqwKLhg+G9UK6kIzj1OC2pkAxvtKV4wd5NG8VB7zHDAPA7qaL BFxjGcShQHm5b22D0L6S5llGRMaqNxFH/N3f5dGwrrkKC4ssR1K+Y6QrfxlVl7wMMc5R uRFA== MIME-Version: 1.0 Received: by 10.182.17.72 with SMTP id m8mr10903577obd.55.1350348584618; Mon, 15 Oct 2012 17:49:44 -0700 (PDT) Received: by 10.182.131.3 with HTTP; Mon, 15 Oct 2012 17:49:44 -0700 (PDT) In-Reply-To: References: <1349390777.5234.9.camel@powernoodle.corp.yahoo.com> Date: Mon, 15 Oct 2012 17:49:44 -0700 Message-ID: Subject: Re: [CFT]hwpmc update for sandybridge-e From: hiren panchasara To: Fabien Thomas Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-current , Davide Italiano X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2012 00:49:46 -0000 On Mon, Oct 15, 2012 at 1:12 AM, Fabien Thomas wr= ote: > > Le 13 oct. 2012 =C3=A0 00:54, hiren panchasara a =C3=A9crit : > > > > > > > On Fri, Oct 5, 2012 at 1:05 AM, Fabien Thomas > wrote: > > > > Le 5 oct. 2012 =C3=A0 10:00, Fabien Thomas a =C3=A9crit : > > > > > > > > Le 5 oct. 2012 =C3=A0 00:46, Sean Bruno a =C3=A9crit : > > > > > >> So, I did the bear minimum and kind of hacked things together withou= t > > >> understanding precisely what I was doing, and I was able to massage > the > > >> sandybridge-e CPUs into giving me some basic functions. > > >> > > >> Comments or concerns before I commit this? > > >> > > >> http://people.freebsd.org/~sbruno/pmc_sandybridge.txt > > > > > > Hi Sean, > > > > > > The only modification required is this one > > > http://svnweb.freebsd.org/base?view=3Drevision&revision=3D237196 > > > > > > but davide@ removed it for a problem that need to be looked at. > > > > Looking at the doc this CPU require a full set of PMC as the list of > event are different. > > So this mean full manpage, full event list, =E2=80=A6 > > > > Doc: > > " > > The events in Table 19-3 apply to > > processors with CPUID signature of DisplayFamily_DisplayModel encoding > with the > > following values: 06_2AH and 06_2DH. The events in Table 19-4 apply to > processors > > with CPUID signature 06_2AH. The events in Table 19-5 apply to > processors with > > CPUID signature 06_2DH. > > " > > > > Required change will be the same as this commit if you want to look at > it: > > http://svnweb.freebsd.org/base?view=3Drevision&revision=3D240164 > > > > Hi All, > > > > With help of Sean, I've prepared another semi-working patch: > > http://www.strugglingcoder.info/patches/hwpmc_sbx_1.txt > > Great, i've quickly looked at the patch: > > I'm not sure to understand why you have removed code in your case for > uncore. > If you dont want to support remove it like for ivy bridge. > Thanks Fabien for getting back quickly. As I am not clear about uncore support, I've removed it entirely as you suggested. I've tried to incorporate other comments too. New set of diffs, pmccontrol and pmctest.py results are here: http://www.strugglingcoder.info/patches/hwpmc_sbx_2.txt http://www.strugglingcoder.info/patches/pmccontrol_2.txt http://www.strugglingcoder.info/patches/pmctestpy_2.txt I now have following event counters failing from pmctest.py script: CYCLE_ACTIVITY.CYCLES_L2_PENDING BACLEARS.ANY L2_TRANS.DEMAND_DATA_RD L2_TRANS.RF0 SQ_MISC.SPLIT_LOCK I am not quite sure why these are failing. Will continue looking into it. Appreciate your help, Hiren