From owner-cvs-all@FreeBSD.ORG  Thu Jul 15 05:46:14 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BF43B16A4CE; Thu, 15 Jul 2004 05:46:14 +0000 (GMT)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8841243D48; Thu, 15 Jul 2004 05:46:14 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.12.11/8.12.11) with ESMTP id i6F5k4mK026902;
	Wed, 14 Jul 2004 22:46:09 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <200407150546.i6F5k4mK026902@gw.catspoiler.org>
Date: Wed, 14 Jul 2004 22:46:04 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
To: alfred@FreeBSD.org
In-Reply-To: <200407150429.i6F4Tm6U037891@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_shutdown.c vfs_subr.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jul 2004 05:46:14 -0000

On 15 Jul, Alfred Perlstein wrote:
> alfred      2004-07-15 04:29:48 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             kern_shutdown.c vfs_subr.c 
>   Log:
>   Tidy up system shutdown.
>   
>   Revision  Changes    Path
>   1.156     +13 -5     src/sys/kern/kern_shutdown.c
>   1.511     +11 -1     src/sys/kern/vfs_subr.c

The message in sched_sync should refer to "vnodes remaining" since that
is what it is counting.  "Syncer syncing disks" sounds somewhat
redundant, since that is its only purpose.  Maybe "Syncer doing final
sync" would be better if verbosity is desirable.

I'd prefer skipping the the final sync() in boot() if there are no dirty
buffers, with a message something like "skipping final sync because no
dirty buffers remain".