From owner-svn-src-all@FreeBSD.ORG Thu Oct 9 06:04:07 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9867078B; Thu, 9 Oct 2014 06:04:07 +0000 (UTC) Received: from mail-ig0-x235.google.com (mail-ig0-x235.google.com [IPv6:2607:f8b0:4001:c05::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47C9C98D; Thu, 9 Oct 2014 06:04:07 +0000 (UTC) Received: by mail-ig0-f181.google.com with SMTP id r10so2244434igi.14 for ; Wed, 08 Oct 2014 23:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=3kPeD1T/neyqSVTv+nMAjvlKno+Ahl55vLU9IeOMHPs=; b=BX6/d6RI3I81w0QqP6OljjhKD1Qh5EEF6Qpf4g/iTFM2iaB4We0LZ4Ei66xArT4YF+ R81Rc0becloTAwwTzU4qgrRIQKDKGFQ/eBlSSCCW8JanCOhwd923Lv2PdpWyRDY3NYMe GTrQW4Eo2VwwLjiM1lDi3yh8UWJm2TvP5RpEOLAjLIEAomMNLOtfkYIGwTesA0xV62rx cOi2MRQvmgNP+KkTKIv9EHffnc+rAPUtErhBmFZ+ovdPXtYW/4NOYxXTbpk3ZsNs5OSz 3OA81ygjHVbUvly6oxBza0RYqNMeBWe06jDGExpqK76SI8kaSlIXwBfGh48ESnP3P+5V yxag== X-Received: by 10.43.108.212 with SMTP id ed20mr4441596icc.12.1412834646648; Wed, 08 Oct 2014 23:04:06 -0700 (PDT) Received: from [10.76.23.9] (mobile-166-137-212-186.mycingular.net. [166.137.212.186]) by mx.google.com with ESMTPSA id f19sm5368567igo.10.2014.10.08.23.04.05 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 08 Oct 2014 23:04:06 -0700 (PDT) References: <201410090553.s995rxHK066788@svn.freebsd.org> Mime-Version: 1.0 (1.0) In-Reply-To: <201410090553.s995rxHK066788@svn.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: <3EB30773-FEC7-4DF9-95A1-E5963FB22112@gmail.com> X-Mailer: iPhone Mail (11D257) From: Garrett Cooper Subject: Re: svn commit: r272805 - head/sys/cam Date: Wed, 8 Oct 2014 23:04:03 -0700 To: Alexander Motin Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2014 06:04:07 -0000 Also... > On Oct 8, 2014, at 22:53, Alexander Motin wrote: >=20 > Author: mav > Date: Thu Oct 9 05:53:58 2014 > New Revision: 272805 > URL: https://svnweb.freebsd.org/changeset/base/272805 >=20 > Log: > Use proper variable when looping through periphs with CAM_PERIPH_FREE. >=20 > PR: 194256 > Submitted by: Scott M. Ferris > MFC after: 3 days > Sponsored by: EMC/Isilon Storage Division >=20 Reported by: Anton Rang > Modified: > head/sys/cam/cam_xpt.c >=20 > Modified: head/sys/cam/cam_xpt.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/cam/cam_xpt.c Thu Oct 9 05:53:04 2014 (r272804) > +++ head/sys/cam/cam_xpt.c Thu Oct 9 05:53:58 2014 (r272805) > @@ -2195,7 +2195,7 @@ xptperiphtraverse(struct cam_ed *device, > next_periph =3D SLIST_NEXT(periph, periph_links); > while (next_periph !=3D NULL && > (next_periph->flags & CAM_PERIPH_FREE) !=3D 0) > - next_periph =3D SLIST_NEXT(periph, periph_links); > + next_periph =3D SLIST_NEXT(next_periph, periph_links); > if (next_periph) > next_periph->refcount++; > mtx_unlock(&bus->eb_mtx); > @@ -2269,7 +2269,7 @@ xptpdperiphtraverse(struct periph_driver > next_periph =3D TAILQ_NEXT(periph, unit_links); > while (next_periph !=3D NULL && > (next_periph->flags & CAM_PERIPH_FREE) !=3D 0) > - next_periph =3D TAILQ_NEXT(periph, unit_links); > + next_periph =3D TAILQ_NEXT(next_periph, unit_links); > if (next_periph) > next_periph->refcount++; > xpt_unlock_buses(); >=20